Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up client/src/models/results #1605

Open
4 tasks
Stephen-ONeil opened this issue Oct 7, 2021 · 0 comments
Open
4 tasks

Clean up client/src/models/results #1605

Stephen-ONeil opened this issue Oct 7, 2021 · 0 comments

Comments

@Stephen-ONeil
Copy link
Contributor

  • break up results.js, it's a big jumble of utils, configuration, and classes
    • start porting to TS in the process
  • Result and Indicator need to be ironed out a fair bit. They look subject-like, but they are definitely not subjects post-TS subject entities #1169.They should probably be their own thing.
    • maybe just some basic classes with utility methods and separate stores?
    • maybe standalone utility methods and direct GQL queries?
      • there's a lot of places where the current populate_results code makes small efficiencies by cross populating one store with the result's of another's queries. Weigh if it's worth the extra abstractions over just using the apollo cache, or see if it's worth trying to manually populate the apollo cache the same way the stores currently cross-populate
@Stephen-ONeil Stephen-ONeil changed the title Clean up models/results Clean up client/src/models/results Oct 7, 2021
@Steph-Rancourt Steph-Rancourt transferred this issue from TBS-EACPD/infobase Jun 6, 2024
@Steph-Rancourt Steph-Rancourt transferred this issue from TBS-EACPD/private-temp Jun 6, 2024
@Steph-Rancourt Steph-Rancourt transferred this issue from another repository Jun 6, 2024
@Steph-Rancourt Steph-Rancourt transferred this issue from TBS-EACPD/private-temp Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant