Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review data/test-data files #1606

Open
Stephen-ONeil opened this issue Jul 7, 2021 · 0 comments
Open

Review data/test-data files #1606

Stephen-ONeil opened this issue Jul 7, 2021 · 0 comments

Comments

@Stephen-ONeil
Copy link
Contributor

Some of the test-data csvs were hand crafted, others are (partial) snapshots of real data from a certain point in time. Hard to tell what special cases either type covers, especially for the later. The snapshots of real data can also be pretty hard to update with new columns/special cases.

It'd take a fair bit of work, but I think we need to start from scratch with totally fake, hand crafted data. Starting from making a variety of fake departments representing various real-world categories, including any special cases we can think of. Where possible, text fields in the fake data should be used to self-document what special cases something represents.

This will mean a hard reset on all the snapshot test baselines. We'll need to be pretty careful to make sure those don't degrade (e.g. lose coverage of some special case). Should result in higher quality and more maintainable snapshot tests at the end of the day though. They should run a good deal faster if we keep things reasonable. For instance, the test indicators.csv is currently nearly 6K lines and the related snapshot file is over 10K. That whole snapshot file needs to be diffed if even a single line in the test output doesn't match it!

Alternatively, rethink our /server testing approach all together.

@Steph-Rancourt Steph-Rancourt transferred this issue from TBS-EACPD/infobase Jun 6, 2024
@Steph-Rancourt Steph-Rancourt transferred this issue from another repository Jun 6, 2024
@Steph-Rancourt Steph-Rancourt transferred this issue from TBS-EACPD/private-temp Jun 6, 2024
@Steph-Rancourt Steph-Rancourt transferred this issue from another repository Jun 6, 2024
@Steph-Rancourt Steph-Rancourt transferred this issue from TBS-EACPD/private-temp Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant