Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add minimum width property, decorated images, and border color #14

Merged
merged 4 commits into from Jan 22, 2019
Merged

add minimum width property, decorated images, and border color #14

merged 4 commits into from Jan 22, 2019

Conversation

logansease
Copy link
Contributor

Needed to add more customizable UI to this segment.
I've added the following:

  • a minimumWidth property to style
  • a selectedBorderColor property to style
  • a new set titles method that also takes an array of selected and normal images that will decorate the right side of the segment bar

Copy link
Owner

@TBXark TBXark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PinterestSegmentCustomizeDelegate has not referenced by other in the code. Is this a necessary protocol ?

@logansease
Copy link
Contributor Author

sorry @TBXark I didn't mean to leave that code there. It's been removed.
I have also added a new normalBorderColor property and a convenience initializer for the image fields

Copy link
Owner

@TBXark TBXark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, This looks good, after I merge the code I will add the add some demo code to the example.

@TBXark TBXark merged commit eb08de4 into TBXark:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants