Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<ref> elements not becoming links in PDF #537

Closed
sydb opened this issue Jan 10, 2022 · 4 comments
Closed

<ref> elements not becoming links in PDF #537

sydb opened this issue Jan 10, 2022 · 4 comments
Assignees
Labels
conversion: pdf resp: StylesheetsGroup Issue is suitable for the group-learning approach taken in the Stylesheets Coop Working Group.

Comments

@sydb
Copy link
Member

sydb commented Jan 10, 2022

From work on #526, @martindholmes and I have discovered that the headwords (as it were) in “1.4.1 Standard Content Models” on PDF page 16 are still not links. They are encoded as <ref>s, not <ident>s, so we did not try to fix them on that ticket.

@sydb sydb added this to the Release 7.53.0 milestone Jan 10, 2022
@sydb sydb added the resp: StylesheetsGroup Issue is suitable for the group-learning approach taken in the Stylesheets Coop Working Group. label Jan 10, 2022
@martinascholger
Copy link
Member

Do you mean <ptr>s? They are links in my PDF download.

@sydb
Copy link
Member Author

sydb commented Jan 28, 2022

Update from Stylesheets group meeting 2022-01-28

@martinascholger’s comment above can be ignored. (I had not been precise enough in the description of where there were problematic <ref>s, so she was looking in wrong place. I meant in the TEI Lite intermediate file, not the source of the Guidelines.)

We discovered that the code in latex/latex_tagdocs.xsl that handles this (roughly lines 290–307)

  1. Does not have a template that matches specList-dataSpec, although it does have the others
  2. Uses <value-of> where surely it should be <apply-templates>
  3. Generates ugly output that is both boldfaced and a link

So (after some testing) we removed the boldface bit from the template for specList-elementSpec and changed the <value-of> to <apply-templates>; and just removed the other templates, since all they were adding was the boldface bit, which we think is ugly, anyway.

And it seems to work. That’s the good news. The bad news is I forgot to make a new branch for this, so it will be a few minutes to hours before I can check it in and generate a PR.

@martindholmes
Copy link
Contributor

@sydb
Copy link
Member Author

sydb commented Jan 29, 2022

Thanks, @martindholmes, that is a nice description. Forgot to say so here, but the changes were pushed up to the "sydb_issue_537" branch at ~16:49Z, and PR #542 (on which you have already commented) created for it at ~16:54Z.

@sydb sydb self-assigned this Feb 28, 2022
@sydb sydb closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conversion: pdf resp: StylesheetsGroup Issue is suitable for the group-learning approach taken in the Stylesheets Coop Working Group.
Projects
None yet
Development

No branches or pull requests

3 participants