Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOC creation for TEI-in-TEI #496

Closed
sydb opened this issue Mar 25, 2021 · 2 comments
Closed

TOC creation for TEI-in-TEI #496

sydb opened this issue Mar 25, 2021 · 2 comments
Assignees
@sydb
Labels
conversion: html resp: StylesheetsGroup Issue is suitable for the group-learning approach taken in the Stylesheets Coop Working Group. status: Go Council has decided the ticket should proceed. status: wontFix While the issue is a concern (bug, worthwhile enhancement etc.), there are no plans to address.
Milestone
Release 7.52.0

Comments

@sydb
Copy link
Member

sydb commented Mar 25, 2021

Now that <TEI> can self-nest, the mainTOC template in ./html/html_textstructure.xsl needs to be updated. (At the very least, test="self::tei:teiCorpus" needs to be test="self::tei:teiCorpus | self::tei:TEI[tei:TEI]", but there may be a lot more.)

(This is status: Go to see what needs to be done, and perhaps do it in a branch.)
@sydb sydb added status: Go Council has decided the ticket should proceed. resp: StylesheetsGroup Issue is suitable for the group-learning approach taken in the Stylesheets Coop Working Group. conversion: html labels Mar 25, 2021
martindholmes added a commit that referenced this issue May 14, 2021
@martindholmes
Test2 files for issue #496.
88e7bc5
martindholmes added a commit that referenced this issue May 14, 2021
@martindholmes
Adding calls to new test files for issue #496.
5c757ba
martindholmes added a commit that referenced this issue May 14, 2021
@martindholmes
First fix for issue #496 for LaTeX.
affc6fc
sydb added a commit that referenced this issue May 14, 2021
@sydb
Try to get nested TOC working:
e5af7cd 
Working #496 with NC & MH, here trying to replace every XPath that looks for teiCorpus to also look for TEI with a child TEI.
martindholmes added a commit that referenced this issue May 14, 2021
@martindholmes
HTML tests are still failing for issue #496, but we've run out of tim…
6a2e4b6 
…e for today.
@martindholmes
Copy link
Contributor

@npcole, @sydb and I made a start on this in branch issue-496-corpus, and got some things working, but HTML is not yet working correctly. Ran out of time.

@sydb
Copy link
Member Author

sydb commented May 28, 2021

This was status GO to see what needs to be done. @martindholmes and I have spent ~2–3 hours together on this problem (one of them with @npcole’s help, too) and have not cracked this nut. (The problem is not that figuring out an XPath that does the right thing is difficult, but rather following the labyrinthine processing chain is a serious stumbling block.)
Thus, at least for the moment, this is going to be “closed, won’t fix”.

@sydb sydb closed this as completed May 28, 2021
@sydb sydb added the status: wontFix While the issue is a concern (bug, worthwhile enhancement etc.), there are no plans to address. label May 28, 2021
martindholmes added a commit that referenced this issue Jun 4, 2021
@martindholmes
Test2 files for issue #496.
0c99396
martindholmes added a commit that referenced this issue Jun 4, 2021
@martindholmes
Adding calls to new test files for issue #496.
6ffce77
martindholmes added a commit that referenced this issue Jun 4, 2021
@martindholmes
First fix for issue #496 for LaTeX.
3ad85d0
martindholmes pushed a commit that referenced this issue Jun 4, 2021
@sydb @martindholmes
Try to get nested TOC working:
8c076d3 
Working #496 with NC & MH, here trying to replace every XPath that looks for teiCorpus to also look for TEI with a child TEI.
martindholmes added a commit that referenced this issue Jun 4, 2021
@martindholmes
HTML tests are still failing for issue #496, but we've run out of tim…
910b8af 
…e for today.
@martinascholger martinascholger added this to the Release 7.52.0 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sydb sydb

Labels
conversion: html resp: StylesheetsGroup Issue is suitable for the group-learning approach taken in the Stylesheets Coop Working Group. status: Go Council has decided the ticket should proceed. status: wontFix While the issue is a concern (bug, worthwhile enhancement etc.), there are no plans to address.
Projects
None yet
Milestone
Release 7.52.0
Development

No branches or pull requests
3 participants
@sydb @martindholmes @martinascholger