Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On the @ident of <constraintSpec> #2223

Closed
sydb opened this issue Jan 28, 2022 · 2 comments
Closed

On the @ident of <constraintSpec> #2223

sydb opened this issue Jan 28, 2022 · 2 comments

Comments

@sydb
Copy link
Member

sydb commented Jan 28, 2022

This ticket is part of the solution to Stylesheets ticket 541.

  1. All of the @idents of all <constraintSpec>s in the Guidelines should be unique.
  2. Part of the build testing process should check for said uniqueness.
  3. A <constraintSpec> should be added to warn users if a duplicate constraintSpec/@ident is created (i.e. with @mode of "add"); this could be used to satisfy (2), above.

I made this HIGH priority because it blocks further progress on the Stylesheets issue.

@martindholmes
Copy link
Contributor

The only reason I can imagine for multiple constraintSpecs with the same ident is if they're simply different language versions of the same constraint, and would need to be processed in the same way (deletion or replacement or whatever) when the same ODD is built in different languages. But there are other ways to achieve that, I guess.

@HelenaSabel
Copy link
Member

PR #2224 addressed this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants