release 1.0-6

[dankelley]

The release of 1.0-5 was on 2017-08-09, i.e. nearly 4 years ago, and GSW-C has evolved a bit in the meantime. Also, as in #46, it is now clear that reliance on testthat was a problematic choice.

Accordingly, I've been working for a few days, to get a new release ready. Some of the work was quite finicky (see the somewhat meandering discussions on #46 and #47), but I think I have it mostly done. I like to do the things that devtools::release() wants me to do, head of time, so here's a checklist to help me keep track:

• clear up some remaining loose ends in the code (recheck the GSW-C/matlab integration, and what I say about that in the docs
• check into the special-case that GSW-C is using for a particular function (see GSW-R (beta) not agreeing with TEOS-10 for gsw_geo_strf_dyn_height() #47)
• do another editing pass on the docs (especially the templates) for clarity
• use pkgdown to redo the old, hand-edited website. (The benefit of using pkgdown is that it can be automated, and it will present a format that will be familiar to users.)
• ensure that R-CMD-check action is okay
• ensure that pkgdown action is okay
• test on winbuilder/develop check_win_devel().
• test on winbuilder/release with check_win_release()
• test on Rhub with rhub::check() answering 14 for ubuntu-gcc-devel
• test on Rhub with rhub::check() answering 5 for debian-gcc-release
• spell check with develop::spell_check()
• examine built-up tarball to ensure that there are no unnecessary files there.
• revdepcheck

[dankelley]

I just submitted it, and got email receipt, as below. I will leave this issue open until it is accepted to CRAN (assuming eventual success).

[This was generated from CRAN.R-project.org/submit.html]

The following package was uploaded to CRAN:
===========================================

Package Information:
Package: gsw
Version: 1.0-6
Title: Gibbs Sea Water Functions
Author(s): Dan Kelley [aut, cre, cph]
 (<https://orcid.org/0000-0001-7808-5911>), Clark Richards [aut,
 cph] (<https://orcid.org/0000-0002-7833-206X>), WG127
 SCOR/IAPSO [aut, cph] (Original 'Matlab' and derived code)
Maintainer: Dan Kelley <dan.kelley@dal.ca>
Depends: R (>= 3.5.0),
Suggests: knitr, rmarkdown, testthat
Description: Provides an interface to the Gibbs 'SeaWater' ('TEOS-10') C
 library, version 3.05 (commit
 'f7bfebf44f686034636facb09852f1d5760c27f5', dated 2021-03-27,
 available at <https://github.com/TEOS-10/GSW-C>, which stems
 from 'Matlab' and other code written by members of Working
 Group 127 of 'SCOR'/'IAPSO' (Scientific Committee on Oceanic
 Research / International Association for the Physical
 Sciences of the Oceans).
License: GPL (>= 2) | file LICENSE


The maintainer confirms that he or she
has read and agrees to the CRAN policies.

Submitter's comment: ## Test environments

* local OS X (11.4, intel)
 install using R-4.1.0
* win-builder (devel and
 release)

## R CMD check results

* 0 errors | 0
 warnings | 0 notes


=================================================

Original content of DESCRIPTION file:

Package: gsw
Version: 1.0-6
Title: Gibbs Sea Water Functions
Authors@R: c(
       person(given="Dan",
           family="Kelley",
           email="dan.kelley@dal.ca",
           role=c("aut","cre","cph"),
           comment=c(ORCID="https://orcid.org/0000-0001-7808-5911")),
       person(given="Clark",
           family="Richards",
           email="clark.richards@gmail.com",
           role=c("aut","cph"),
           comment=c(ORCID="https://orcid.org/0000-0002-7833-206X")),
       person(given="WG127",
           family="SCOR/IAPSO",
           role=c("aut","cph"),
           comment="Original 'Matlab' and derived code"))
Copyright: Original algorithms and 'Matlab'/C library (c) 2015-2021
       WG127 SCOR/IAPSO (Scientific Committee on Oceanic Research /
       International Association for the Physical Sciences of the
       Oceans, Working Group 127); C wrapper code and R code (c)
       2015-2021 Dan Kelley and Clark Richards
Maintainer: Dan Kelley <dan.kelley@dal.ca>
Depends: R (>= 3.5.0),
Suggests: knitr, rmarkdown, testthat
BugReports: https://github.com/TEOS-10/GSW-R/issues
Description: Provides an interface to the Gibbs 'SeaWater' ('TEOS-10') C library, version 3.05 (commit 'f7bfebf44f686034636facb09852f1d5760c27f5', dated 2021-03-27, available at <https://github.com/TEOS-10/GSW-C>, which stems from 'Matlab' and other code written by members of Working Group 127 of 'SCOR'/'IAPSO' (Scientific Committee on Oceanic Research / International Association for the Physical Sciences of the Oceans).
URL: http://teos-10.github.io/GSW-R/,
       https://teos-10.github.io/GSW-R/index.html
License: GPL (>= 2) | file LICENSE
LazyLoad: yes
LazyData: no
Packaged: 2021-07-07 17:05:52 UTC; kelley
Encoding: UTF-8
RoxygenNote: 7.1.1
BuildVignettes: true
VignetteBuilder: knitr
NeedsCompilation: yes
Author: Dan Kelley [aut, cre, cph] (<https://orcid.org/0000-0001-7808-5911>),
 Clark Richards [aut, cph] (<https://orcid.org/0000-0002-7833-206X>),
 WG127 SCOR/IAPSO [aut, cph] (Original 'Matlab' and derived code)

[dankelley]

It got through the revdep checks on the CRAN test machines, and I got an email (below) indicating that it's on the way to CRAN now.

Dear maintainer,

thanks, package gsw_1.0-6.tar.gz is on its way to CRAN.

Best regards,
CRAN teams' auto-check service
Package check result: OK

No changes to worse in reverse depends.

[dankelley]

Below is a link to where the tests were made. Possibly, the remaining steps will be documented there also.

https://win-builder.r-project.org/incoming_pretest/gsw_1.0-6_20210707_190658/

[dankelley]

I see it listed on CRAN now. So far, it's only available as source [1], but it has passed two checks [2]. I will keep this issue open until this version appears throughout [1] and [2], checking every day or so.

1 https://cran.r-project.org/web/packages/gsw/index.html (made into a checklist below)

• Source
• Windows r-devel
• Windows r-devel-UCRT
• Windows r-release
• Windows r-oldrel
• macOS r-release (arm64)
• macOS r-release (x86_64)
• macOS r-oldrel

2 https://cran.r-project.org/web/checks/check_results_gsw.html (made into a checklist below)

• r-devel-linux-x86_64-debian-clang
• r-devel-linux-x86_64-debian-gcc
• r-devel-linux-x86_64-fedora-clang
• r-devel-linux-x86_64-fedora-gcc
• r-devel-windows-x86_64
• r-devel-windows-x86_64-gcc10-UCRT
• r-patched-linux-x86_64
• r-patched-solaris-x86
• r-release-linux-x86_64
• r-release-macos-arm64
• r-release-macos-x86_64
• r-release-windows-ix86+x86_64
• r-oldrel-macos-x86_64
• r-oldrel-windows-ix86+x86_64

[dankelley]

I'm going to close this issue now, since the release has built cleanly on all platforms except r-release-macos-arm64, which seems to be quite slow to build things. For example, that system is 5 weeks behind for sf package. (I think it might be a single mac mini, keeping up with something like 20K packages and likely doing lots of builds of R itself.)