Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we remove Manifest.toml? #21

Closed
Alexander-Barth opened this issue Jun 29, 2022 · 2 comments
Closed

Should we remove Manifest.toml? #21

Alexander-Barth opened this issue Jun 29, 2022 · 2 comments

Comments

@Alexander-Barth
Copy link
Member

Alexander-Barth commented Jun 29, 2022

The repository now includes a Project.toml (supported with the version range of dependencies) and a Manifest.toml (specific version of the complete dependency tree). Given the discussion here and here I am wondering if we should not remove the Manifest.toml to reduce the potential of versioning conflicts.

@dankelley
Copy link

The links you provide suggest not to include Manifest.toml.

These files are generated by Julia, as is indicated by their first lines. Generally, my git policy is to avoid including such files in any sort of project, Julia or not. By analogy, in a C/C++ based project, we would not include .o files, which are generated by the compiler. A problem with including such things in a repo is that the developers might start receiving some ill-thought-out pull requests, as novice users might think that changes ought to be transmitted back upstream.

It's pretty easy to add it back to the repo, if problems arise.

@kouketsu
Copy link
Collaborator

kouketsu commented Nov 3, 2022

Thank you for the suggestion & comments.
I deleted Manifest.toml to try it out.

@kouketsu kouketsu closed this as completed Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants