Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat bump? #25

Closed
willcoxe opened this issue Nov 26, 2022 · 2 comments
Closed

Compat bump? #25

willcoxe opened this issue Nov 26, 2022 · 2 comments

Comments

@willcoxe
Copy link

Can we bump Compat to a higher version?

Right now this package is blocking any DataFrames.jl package more recent than v0.21 and several others. I have tested whether at least my code using GSW still works on a repo clone with Compat set to include '4' and for me nothing breaks (but I have not tested all functions, just the ones I use).

Thanks in advance!

@Alexander-Barth
Copy link
Member

Dear @kouketsu, I just had the the same issue. I think we can remove the dependency to Compat. All test continue to work:

https://github.com/TEOS-10/GibbsSeaWater.jl/actions/runs/3732882897

Can you merge the PR #28 if you agree?

@kouketsu
Copy link
Collaborator

Thanks @Alexander-Barth.
I've merged it.

Please check as
pkg> add GibbsSeaWater#master

I will bump version after solving some other issues (around the beginning of next year).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants