This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
Update Command_nickclean.java #202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Focusvity
reviewed
May 27, 2020
src/main/java/me/totalfreedom/totalfreedommod/command/Command_nickclean.java
Outdated
Show resolved
Hide resolved
|
sorry for being nitpicky but i think you should update the description of the command to reflect the changes made here |
Wild1145
suggested changes
Jun 2, 2020
| @@ -12,7 +12,7 @@ | |||
| import org.bukkit.entity.Player; | |||
|
|
|||
| @CommandPermissions(level = Rank.SUPER_ADMIN, source = SourceType.BOTH) | |||
| @CommandParameters(description = "Essentials Interface Command - Remove illegal chatcodes from nicknames of all players on server.", usage = "/<command>", aliases = "nc") | |||
| @CommandParameters(description = "Essentials Interface Command - Remove illegal chatcodes from nicknames of all players on server.", usage = "/<command> <player | -a>", aliases = "nc") | |||
There was a problem hiding this comment.
No longer is accurately describing what the command does.
| FUtil.adminAction(sender.getName(), "Cleaning all nicknames", false); | ||
|
|
||
| for (final Player player : server.getOnlinePlayers()) | ||
| if (args.length != 1) |
There was a problem hiding this comment.
Any reason not to default to current behavior?
| final String playerName = player.getName(); | ||
| final String nickName = plugin.esb.getNickname(playerName); | ||
| FUtil.adminAction(sender.getName(), "Cleaning " + player.getName() + "'s nickname", false); |
There was a problem hiding this comment.
Does this need to be broadcasted to all players?
|
Doing this differently. The way I'm doing this is you can optionally specify a specific player, but it defaults to it's original clean all nicknames. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://totalfreedom.boards.net/thread/66931/nickclean-1-person per this suggestion, an option to switch /nickclean to /nickclean <player | -a>
sorry i've never done this before and i already went in game and tested it, works.