Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for opencast recording management #1099

Draft
wants to merge 17 commits into
base: develop
Choose a base branch
from
Draft

Add support for opencast recording management #1099

wants to merge 17 commits into from

Conversation

SamuelWei
Copy link
Collaborator

@SamuelWei SamuelWei commented May 22, 2024 •
edited

Fixes #1068

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Change recording mode (Integrated / Opencast)
  • Disable recording managment API, jobs, etc. if recording mode is not integrated
  • Hide recordings tab if recording mode is not integrated
  • Add OpenCastRecordingPlugin to customize metadata send to BBB

ToDo

  • Test with community and real OpenCast to validate metadata

@SamuelWei SamuelWei linked an issue May 22, 2024 that may be closed by this pull request
support for recordings in Opencast #1068
Open
@codecov Codecov
Copy link

codecov bot commented May 22, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.90%. Comparing base (7396f04) to head (76c556c).
Report is 9 commits behind head on develop.

❗ Current head 76c556c differs from pull request most recent head 3d74ac5

Please upload reports for the commit 3d74ac5 to get more accurate results.

Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #1099      +/-   ##
=============================================
+ Coverage      95.84%   95.90%   +0.06%     
- Complexity      1294     1306      +12     
=============================================
  Files            198      199       +1     
  Lines           4425     4471      +46     
=============================================
+ Hits            4241     4288      +47     
+ Misses           184      183       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelWei SamuelWei marked this pull request as ready for review May 23, 2024 09:23
@SamuelWei
Copy link
Collaborator Author

@danielmachill Do not merge after successful review, as tests with a real OpenCast server are still missing.
The added tests are just a check if PILOS does what it is supposed to do according to my understanding of the specification. However, my understanding of the specification may be incorrect or incomplete.

@SamuelWei SamuelWei added this to the v4.0 milestone May 23, 2024
@SamuelWei
Merge branch 'develop' of github.com:THM-Health/PILOS into 1068-suppo…
92cb694 
…rt-for-recordings-in-opencast

# Conflicts:
#	CHANGELOG.md
@SamuelWei
Change metadata to use full name not the user id
1656e92 
Replace meta_opencast-dc-creator and meta_opencast-dc-rightsHolder to contain the users full name, add meta_opencast-series-dc-creator and meta_opencast-series-dc-rightsholder
@SamuelWei
Fix typo
76c556c
@SamuelWei
Update RoomTabSection.vue
3d74ac5
@SamuelWei SamuelWei removed this from the v4.0 milestone Jun 12, 2024
@SamuelWei
Copy link
Collaborator Author

Integration is more complex, as Opencast requires a listing feature in PILOS to make this work.
Can be achieved using the LTI Integration

@SamuelWei SamuelWei marked this pull request as draft June 12, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmachill danielmachill danielmachill left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support for recordings in Opencast
2 participants
@SamuelWei @danielmachill