Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (372f4cd) to head (ead5e0b).

@@              Coverage Diff              @@
##             develop     #574      +/-   ##
=============================================
+ Coverage      95.82%   95.86%   +0.03%     
- Complexity      1288     1295       +7     
=============================================
  Files            198      198              
  Lines           4412     4430      +18     
=============================================
+ Hits            4228     4247      +19     
+ Misses           184      183       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

If the room type settings are changed in the meantime, the room type is always 'reset'. Only refreshing the list solves this issue.

If the room type settings are changed in the meantime, the room type is always 'reset'. Only refreshing the list solves this issue.

2023-09-19.17-06-27.mp4

Looks like this bug already exists

If the room type settings are changed in the meantime, the room type is always 'reset'. Only refreshing the list solves this issue.
2023-09-19.17-06-27.mp4

Looks like this bug already exists

I would suggest to resolve this issue in a separate pull request.

I continue trying to fix the listed errors in the PHP checks.

I'm not sure whether it's a CI configuration issue or a problem caused by the changes in this pull request. My guess is the former.

@dennis531 I'll have a look

If the room type settings are changed in the meantime, the room type is always 'reset'. Only refreshing the list solves this issue.
2023-09-19.17-06-27.mp4

Looks like this bug already exists

I would suggest to resolve this issue in a separate pull request.

I continue trying to fix the listed errors in the PHP checks.

@dennis531 I fixed the issue

@SamuelWei what does this need need now to be merged?

@SamuelWei what does this need need now to be merged?

@tibroc Frontend and backend tests; if I havn't missed it, the custom params are shown in the UI once the type is changed, but they should also be applied on creating a new room with this type; to improve the UX it might also be good to show the user what settings will be changed, giving the user to option to accept oder dismiss the changes.

@dennis531 @tibroc We are currently working on something similar in https://github.com/THM-Health/PILOS/tree/695-restructure-room-settings-page

As soon as this is finished, we will have an other look at this PR and see how we can integrate this