Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item system redesign? #123

Open
TML233 opened this issue Dec 16, 2023 · 0 comments · May be fixed by #143
Open

Item system redesign? #123

TML233 opened this issue Dec 16, 2023 · 0 comments · May be fixed by #143
Assignees
Labels
enhancement New feature and enhancement. proposal Things need discussions.

Comments

@TML233
Copy link
Owner

TML233 commented Dec 16, 2023

Items don't actually need an object. They can be achieved using structs.
Current object-based item system doesn't work very well if you only need to get some data from the item, like name and price. It will create an instance of the item object, get the data and instantly destroy it, which is not very efficient and elegant.

@TML233 TML233 added proposal Things need discussions. enhancement New feature and enhancement. labels Dec 16, 2023
@SheepYhangCN SheepYhangCN self-assigned this Aug 7, 2024
@SheepYhangCN SheepYhangCN added this to In progress in Undertale Engine Refreshed Aug 7, 2024
@SheepYhangCN SheepYhangCN linked a pull request Aug 7, 2024 that will close this issue
@SheepYhangCN SheepYhangCN linked a pull request Aug 7, 2024 that will close this issue
Undertale Engine Refreshed automation moved this from In progress to Done Aug 7, 2024
@TML233 TML233 reopened this Aug 8, 2024
@SheepYhangCN SheepYhangCN linked a pull request Aug 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature and enhancement. proposal Things need discussions.
Projects
Development

Successfully merging a pull request may close this issue.

2 participants