Adding IConsulClientFactory and BaseConsulClientFactory

Consul/Client.cs

@@ -10,6 +10,7 @@
 using System.Net.Http.Headers;
 using System.Linq;
 using System.Security.Cryptography.X509Certificates;
+using Consul.Interfaces;
 
 namespace Consul
 {
@@ -470,6 +471,17 @@ public ConsulClient(ConsulClientConfiguration config, HttpClient client)
             }
         }
 
+        /// <summary>
+        /// Initializes a new Consul client using a <see cref="IConsulClientFactory"/> to initialize the HttpClient and the Configuration
+        /// </summary>
+        /// <param name="clientFactory">Factoty to initialzie the configuration and the Http client</param>
+        public ConsulClient(IConsulClientFactory clientFactory)
+        {
+            Config = clientFactory.CreateConsulConfiguration();
+
+            HttpClient = clientFactory.CreateHttpClient();
+        }
+
         #region IDisposable Support
         private bool disposedValue = false; // To detect redundant calls
 

Consul/Consul.csproj

@@ -56,6 +56,7 @@
     <Compile Include="Event.cs" />
     <Compile Include="Health.cs" />
     <Compile Include="Client.cs" />
+    <Compile Include="Interfaces\IConsulClientFactory.cs" />
     <Compile Include="Interfaces\ICoordinateEndpoint.cs" />
     <Compile Include="Interfaces\IDisposableLock.cs" />
     <Compile Include="Interfaces\IDistributedLock.cs" />
@@ -73,6 +74,7 @@
     <Compile Include="Interfaces\ISessionEndpoint.cs" />
     <Compile Include="Interfaces\IStatusEndpoint.cs" />
     <Compile Include="PreparedQuery.cs" />
+    <Compile Include="Utilities\BaseConsulClientFactory.cs" />
     <Compile Include="Utilities\JsonConverters.cs" />
     <Compile Include="KV.cs" />
     <Compile Include="Lock.cs" />

Consul/Interfaces/IConsulClientFactory.cs

@@ -0,0 +1,22 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Net.Http;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace Consul.Interfaces
+{
+
+    /// <summary>
+    /// Intializes the building blocks to create a dully functioning <see cref="ConsulClient"/>
+    /// </summary>
+    public interface IConsulClientFactory
+    {
+
+        ConsulClientConfiguration CreateConsulConfiguration();
+
+        HttpClient CreateHttpClient();
+
+    }
+}

Consul/Utilities/BaseConsulClientFactory.cs

@@ -0,0 +1,55 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Net.Http;
+using System.Net.Http.Headers;
+using System.Text;
+using System.Threading.Tasks;
+using Consul.Interfaces;
+
+namespace Consul.Utilities
+{
+    /// <summary>
+    /// Basic implementation of <see cref="IConsulClientFactory"/>
+    /// </summary>
+    /// <remarks>
+    /// This basic structure provide a working <see cref="ConsulClient"/>.
+    /// If you wish to change the following settings, please inhrit from the base class and override the necessary settings.
+    /// </remarks>
+    public  class BaseConsulClientFactory : IConsulClientFactory
+    {
+        virtual public ConsulClientConfiguration CreateConsulConfiguration()
+        {
+            return new ConsulClientConfiguration();
+        }
+
+        /// <summary>
+        /// Creates new instance of <see cref="HttpClient"/>
+        /// </summary>
+        /// <remarks>
+        /// Please note, the HttpClient must accept the "application/json" content, if you override this method please make sure you call the base method or add the header manually.
+        /// </remarks>
+        /// <returns></returns>
+        virtual public HttpClient CreateHttpClient()
+        {
+            var httpClient = new HttpClient(CreateHttpHandler())
+            {
+                Timeout = TimeSpan.FromMinutes(15)
+
+            };
+
+            httpClient.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
+
+           httpClient.DefaultRequestHeaders.Add("Keep-Alive","true");
+
+            return httpClient;
+
+        }
+
+        //Other entities should not have access to this nethod, the CreateHttpClient only should call this method.
+        virtual protected WebRequestHandler CreateHttpHandler()
+        {
+            return new WebRequestHandler();
+        }
+    }
+}