Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class file import should be resilient against broken class files #9

Closed
codecholeric opened this issue May 27, 2017 · 0 comments
Closed

Comments

@codecholeric
Copy link
Collaborator

Currently one broken file evil.class breaks the whole import causing an exception. It would be more convenient, to just log a warning and move on.
How to reproduce:

echo "broken" > /some/test/folder/Evil.class
cp some.GoodClass.class /some/test/folder

then

JavaClasses classes = new ClassFileImporter().importPath(Paths.get("/some/test/folder"));

Expected: some.GoodClass to be imported
Actual: Import dies with an exception

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant