Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid pom for jgiven-spring-junit5 #1013

Closed
jangalinski opened this issue Oct 18, 2022 · 4 comments · Fixed by #1014
Closed

invalid pom for jgiven-spring-junit5 #1013

jangalinski opened this issue Oct 18, 2022 · 4 comments · Fixed by #1014
Assignees

Comments

@jangalinski
Copy link
Contributor

After updating to 1.2.3 I keep getting the following build warning:

[WARNING] The POM for com.tngtech.jgiven:jgiven-spring-junit5:jar:1.2.3 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details

@l-1squared
Copy link
Collaborator

Indeed it is not.
I think I identified the issue: The version of the provided scope dependency junit-jupiter is missing. My guess is that this happened because I introduced a version catalogue recently, which imports the junit-platform (=bom) so that I can have the actual dependencies without versions.
Aparently that is not compatible with the maven release. I need to check how to fix this and I'll try to have a fix ready by Thursday

@jangalinski
Copy link
Contributor Author

No need to hurry, it is just a warning and the framework seems to continue working as expected ... but thanks for taking care!

@l-1squared
Copy link
Collaborator

l-1squared commented Oct 18, 2022

I tried to somehow get the version of the dependency form inside gradle via
configurations.compileOnly.resolvedConfiguration.firstLevelModuleDependencies.findAll { it.moduleName == dependency }[0].moduleVersion (https://gist.github.com/dudadornelles/be0bea9f98d3aa17404c)
which I found on the web. Funnily enough executing it tells me that "compileOnly" is not a resolveable dependency configuration. Which is probably the actual root of the problem.

@l-1squared
Copy link
Collaborator

My PR should fix it, but I'd like to see if I can appropriate one of the example projects to safeguard against such a thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants