New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow javascript links in JGiven menu links #146

Closed

nikowitt opened this issue Oct 15, 2015 · 1 comment

Labels

enhancement HTML Report

Milestone

Contributor

nikowitt commented Oct 15, 2015

Hi Jan,

I've just implemented custom links in the reporter, one containing "javascript:window.history.back()". It seems that javascript explicitely has to be whitelisted in AngularJS (https://stackoverflow.com/questions/15606751/angular-changes-urls-to-unsafe-in-extension-page), so is it OK for you to do this?

Best regards,
Niko

Contributor

janschaefer commented Oct 15, 2015

I think this shouldn't be a problem, as you yourself are completely responsible for what you configure ;-)

janschaefer added enhancement HTML Report labels

janschaefer added this to the v0.9.3 milestone

janschaefer closed this as completed in

4c0b548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment