Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Junit5 issues with Spring integration #369

Closed
mmadson opened this issue Oct 3, 2018 · 4 comments
Closed

Junit5 issues with Spring integration #369

mmadson opened this issue Oct 3, 2018 · 4 comments

Comments

@mmadson
Copy link

mmadson commented Oct 3, 2018

Spring integration workaround:

  • exclude jgiven-junit from jgiven-spring dependency
  • create new base class SpringJunit5ScenarioTest extending both SpringExtension and JGivenExtension, also implement BeanFactoryAware to set the scenario's stage creator.

CaseAs workaround:

  • In Junit5 parameterized test call getScenario().getScenarioCaseModel().setDescription() to set the case description using whatever parameter values you need.

It would be great if these workarounds were not necessary and CaseAs worked properly with junit5 parameterized tests.

@mmadson mmadson changed the title Spring + Junit5 Junit5 issues with Spring integration and CaseAs Oct 5, 2018
@janschaefer
Copy link
Contributor

Ok. So these are two issues then, right?

@janschaefer janschaefer added this to the v0.17.0 milestone Oct 19, 2018
@mmadson
Copy link
Author

mmadson commented Oct 22, 2018

Yes, I suppose it is 2 issues. Not sure if you want me to split it or not.

@janschaefer
Copy link
Contributor

I created a new one for the CaseAs issue. #372

@janschaefer janschaefer modified the milestones: v0.17.0, v0.18.0 Nov 10, 2018
@janschaefer janschaefer changed the title Junit5 issues with Spring integration and CaseAs Junit5 issues with Spring integration Nov 10, 2018
@janschaefer janschaefer modified the milestones: v0.18.0, v1.0.0 Jan 20, 2019
@janschaefer
Copy link
Contributor

Will be addressed with #419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants