Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Featured data collections section on homepage fetches all collections from API instead of first three #483

Closed
ctrepka opened this issue Sep 8, 2023 · 1 comment
Closed

Featured data collections section on homepage fetches all collections from API instead of first three #483

ctrepka opened this issue Sep 8, 2023 · 1 comment
Assignees
@ctrepka @aziza-twdb
Labels
Cleanup Messy situation needs cleaning up Enhancement New feature or request Future Long term future enhancement
Projects
tnris.org

Comments

@ctrepka
Copy link
Contributor

ctrepka commented Sep 8, 2023 •
edited
Loading

Expected Behavior

only first three collections should be fetched from API to avoid bloated payload

Actual Behavior

all collections are fetched from API, resulting in large payload

Solution

Use API query parameters to sort and request only the data that is needed

Related Issues

#481
#482
@ctrepka ctrepka added Enhancement New feature or request Cleanup Messy situation needs cleaning up Future Long term future enhancement labels Sep 8, 2023
@ctrepka
Copy link
Contributor Author

ctrepka commented Sep 8, 2023

Suggested Fix

add ?limit=3&ordering=publication_date to end of url

@aziza-twdb aziza-twdb mentioned this issue Sep 13, 2023
Closed
@space-longoria space-longoria added this to Work In Progress in tnris.org Sep 14, 2023
@aziza-twdb aziza-twdb moved this from Work In Progress to Live on tnris.org in tnris.org May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctrepka ctrepka

@aziza-twdb aziza-twdb

Labels
Cleanup Messy situation needs cleaning up Enhancement New feature or request Future Long term future enhancement
Projects
tnris.org
Live on tnris.org
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ctrepka @aziza-twdb