Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Alerce Alert Cone search #691

Closed
jchate6 opened this issue Sep 25, 2023 · 1 comment · Fixed by #692
Closed

Error in Alerce Alert Cone search #691

jchate6 opened this issue Sep 25, 2023 · 1 comment · Fixed by #692
Assignees
Labels
alert brokers Alert Brokers bug Something isn't working

Comments

@jchate6
Copy link
Contributor

jchate6 commented Sep 25, 2023

stack trace:

Internal Server Error: /alerts/query/18/run/
Traceback (most recent call last):
  File "/home/jchatelain/git/tom_base/env_tombase/lib64/python3.10/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
  File "/home/jchatelain/git/tom_base/env_tombase/lib64/python3.10/site-packages/django/core/handlers/base.py", line 199, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/home/jchatelain/git/tom_base/env_tombase/lib64/python3.10/site-packages/django/core/handlers/base.py", line 362, in process_exception_by_middleware
    response = middleware_method(request, exception)
  File "/home/jchatelain/git/tom_base/tom_common/middleware.py", line 29, in process_exception
    raise exception
  File "/home/jchatelain/git/tom_base/env_tombase/lib64/python3.10/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/jchatelain/git/tom_base/env_tombase/lib64/python3.10/site-packages/django/views/generic/base.py", line 104, in view
    return self.dispatch(request, *args, **kwargs)
  File "/home/jchatelain/git/tom_base/env_tombase/lib64/python3.10/site-packages/django/views/generic/base.py", line 143, in dispatch
    return handler(request, *args, **kwargs)
  File "/home/jchatelain/git/tom_base/env_tombase/lib64/python3.10/site-packages/django/views/generic/base.py", line 226, in get
    context = self.get_context_data(**kwargs)
  File "/home/jchatelain/git/tom_base/tom_alerts/views.py", line 231, in get_context_data
    alert_query_results = broker_class.fetch_alerts(deepcopy(query.parameters))
  File "/home/jchatelain/git/tom_base/tom_alerts/brokers/alerce.py", line 320, in fetch_alerts
    if len(alerts) > 0 and response['page'] < parameters.get('max_pages', 1):
TypeError: '<' not supported between instances of 'NoneType' and 'int'
Internal Server Error: /alerts/query/18/run/
Traceback (most recent call last):
  File "/home/jchatelain/git/tom_base/env_tombase/lib64/python3.10/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
  File "/home/jchatelain/git/tom_base/env_tombase/lib64/python3.10/site-packages/django/core/handlers/base.py", line 199, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/home/jchatelain/git/tom_base/env_tombase/lib64/python3.10/site-packages/django/core/handlers/base.py", line 362, in process_exception_by_middleware
    response = middleware_method(request, exception)
  File "/home/jchatelain/git/tom_base/tom_common/middleware.py", line 29, in process_exception
    raise exception
  File "/home/jchatelain/git/tom_base/env_tombase/lib64/python3.10/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/jchatelain/git/tom_base/env_tombase/lib64/python3.10/site-packages/django/views/generic/base.py", line 104, in view
    return self.dispatch(request, *args, **kwargs)
  File "/home/jchatelain/git/tom_base/env_tombase/lib64/python3.10/site-packages/django/views/generic/base.py", line 143, in dispatch
    return handler(request, *args, **kwargs)
  File "/home/jchatelain/git/tom_base/env_tombase/lib64/python3.10/site-packages/django/views/generic/base.py", line 226, in get
    context = self.get_context_data(**kwargs)
  File "/home/jchatelain/git/tom_base/tom_alerts/views.py", line 231, in get_context_data
    alert_query_results = broker_class.fetch_alerts(deepcopy(query.parameters))
  File "/home/jchatelain/git/tom_base/tom_alerts/brokers/alerce.py", line 320, in fetch_alerts
    if len(alerts) > 0 and response['page'] < parameters.get('max_pages', 1):
TypeError: '<' not supported between instances of 'NoneType' and 'int'

This looks to be a change in the response.json() from Alerce with respect to page.

@jchate6 jchate6 added the bug Something isn't working label Sep 25, 2023
@jchate6 jchate6 self-assigned this Sep 25, 2023
@jchate6
Copy link
Contributor Author

jchate6 commented Sep 27, 2023

This seems to be a bug on the ALeRCE side. (https://api.alerce.online/ztf/v1)
Pagination does not seem to work properly without count=true and even then no page is provided.

@jchate6 jchate6 linked a pull request Sep 27, 2023 that will close this issue
@jchate6 jchate6 added the alert brokers Alert Brokers label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert brokers Alert Brokers bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant