Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typechecking callbacks #86

Open
Tracked by #84
tolauwae opened this issue Sep 16, 2022 · 1 comment
Open
Tracked by #84

Typechecking callbacks #86

tolauwae opened this issue Sep 16, 2022 · 1 comment
Labels
feature Minor new feature or request

Comments

@tolauwae
Copy link
Member

tolauwae commented Sep 16, 2022 •
edited
Loading

Runtime typechecking of the callbacks: do we do this in the callback handling system or in the primitives?
@tolauwae tolauwae added the feature Minor new feature or request label Sep 16, 2022
@tolauwae tolauwae changed the title Typecheck callbacks Typechecking callbacks Sep 16, 2022
This was referenced Sep 16, 2022
Closed
Closed
@carllocos
Copy link
Contributor

I propose the primitives because then we just need to type check once: during the call to subscribe_interrupt. Whereas during the callback handling, we would then have to typecheck before handling the events which I believe occurs much more.

Unless it is possible to overwrite in Wasm a table entry to point to another function that has another type signature but I don't think that such thing is possible in Wasm.

@tolauwae tolauwae mentioned this issue May 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Minor new feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carllocos @tolauwae