Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] AWS specific code should be relocated to another repo/package #121

Closed
ardunn opened this issue Oct 13, 2020 · 2 comments · Fixed by #296
Closed

[Bug] AWS specific code should be relocated to another repo/package #121

ardunn opened this issue Oct 13, 2020 · 2 comments · Fixed by #296
Labels
bug Something isn't working

Comments

@ardunn
Copy link
Collaborator

ardunn commented Oct 13, 2020

Problem

Most users will not be using AWS to run beep (or if I am wrong here please correct). The AWS code is mixed in with beep, between the various required configs, extra tests, and extra submodules, there is a clear conceptual separation of beep and AWS deployment but no such separation is reflected in the code; it's all mixed together.

Solution

Move the AWS specific stuff to another repo (e.g., a private deployment repo). Make specific beep versions requirements of the deployment repo

@patrickherring-TRI
Copy link
Contributor

@ardunn Yeah, this is a good point. I am acutally in the process of removing a bunch of the AWS stuff since we are transitioning away from those tools. Hopefully that should clear up the problems you are seeing here.

@ardunn
Copy link
Collaborator Author

ardunn commented Oct 30, 2020

file list includes:

test_workflow.py
test_s3.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants