Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Half cell model voltage hold potential incorrect #115

Open
lightningclaw001 opened this issue Feb 22, 2023 · 1 comment
Open

Half cell model voltage hold potential incorrect #115

lightningclaw001 opened this issue Feb 22, 2023 · 1 comment

Comments

@lightningclaw001
Copy link
Collaborator

A slight technicality for people who want to do voltage hold on half cells. For half cell models the voltage pulse should only be on the solid electrical potential. However, the half cell concentrated solution models include the kBTln(a_l) calculation implicitly in the electrical potential. This is technically incorrect but only a problem for people who are using the half cell voltage holds with the concentrated electrolyte model (probably only me right now), but keeping track of this in case people do see this problem in the future.

E.g. in the function calc_mu_O in mod_electrodes.py,
mu_lyte = T*np.log(act_lyte) + phi_lyte
should be true for both the SM and dilute models.

@lightningclaw001
Copy link
Collaborator Author

This is a very quick fix but may break some half cell tests slightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant