Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated tend value when working with segments is not used #52

Open
loostrum opened this issue Apr 14, 2021 · 0 comments
Open

Updated tend value when working with segments is not used #52

loostrum opened this issue Apr 14, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@loostrum
Copy link
Collaborator

The following piece of code in io_utils.py is supposed to avoid extrapolation by changing tend:

if "segments" in ndD_s["profileType"]:
    dD_s["tend"] = dD_s["segments_tvec"][-1]
    # Pad the last segment so no extrapolation occurs
    dD_s["segments_tvec"][-1] = dD_s["tend"]*1.01

However, this change is only applied to the dimensional config dict, after the non-dimensional version was already created from it a few lines above. The simulation used only the non-dimensional config, so the old tend is used instead of the updated value.

@d-cogswell d-cogswell added the bug Something isn't working label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants