Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] CF for x265 does not include HEVC #1600

Closed
2 of 20 tasks
gjobin opened this issue Oct 19, 2023 · 4 comments
Closed
2 of 20 tasks

[Bug] CF for x265 does not include HEVC #1600

gjobin opened this issue Oct 19, 2023 · 4 comments
Labels
Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats Priority: Low Status: Non Issue Non-Issue. No Action Needed

Comments

@gjobin
Copy link

gjobin commented Oct 19, 2023

Guide Name

  • Bazarr
  • Downloaders/Deluge
  • Downloaders/NZBGet
  • Downloaders/Qbittorrent
  • Downloaders/ruTorrent
  • Downloaders/SABnzbd
  • Downloaders/Other
  • Guide-Sync
  • Hardlinks/Docker
  • Hardlinks/Dockstarter
  • Hardlinks/Native
  • Hardlinks/Synology
  • Hardlinks/TrueNAS-Core
  • Hardlinks/Unraid
  • Misc
  • Plex
  • Prowlarr
  • Radarr
  • Sonarr
  • Other

Description

Comparing the x265 related CF's, the basic one does not properly include "HEVC" like the other do.
image

Thank you.

Expected Behavior

HEVC should match x265 custom format.

Screenshots

No response

Additional Context

Applies to both Sonarr and Radarr
@gjobin gjobin added Status: Triage Needed New Issue Requiring Triage Type: Bug Found a BUG/Error in the Guide labels Oct 19, 2023
@bakerboy448
Copy link
Contributor

Condition Naming issue only; not a material bug

the CF still includes hevc

"[xh][ ._-]?265|\bHEVC(\b|\d)"

@bakerboy448 bakerboy448 added Area: Sonarr Sonarr Related Area: Radarr Radarr Related Area: Starr Custom Formats Issue is related to custom formats Priority: Low and removed Status: Triage Needed New Issue Requiring Triage labels Oct 19, 2023
@gjobin
Copy link
Author

gjobin commented Oct 20, 2023

Condition Naming issue only; not a material bug

the CF still includes hevc

"[xh][ ._-]?265|\bHEVC(\b|\d)"

That is interesting, cause the CF label did not show on a movie containing HEVC.
There definitely are cases where it does not seem to work as expected, but would like to understand if I am mistaken.
You're right though, labeling does'nt matter, and did not check down to the Regex.

Working Case :
image

Seemingly incorrect case :
image

@bakerboy448
Copy link
Contributor

Non-issue x265 is confined to REMUX releases only. Not BR-DISK

@TRaSH- TRaSH- added Status: Non Issue Non-Issue. No Action Needed and removed Type: Bug Found a BUG/Error in the Guide labels Oct 20, 2023
@gjobin
Copy link
Author

gjobin commented Oct 20, 2023

Makes sense. Sorry I did not catch that.

@gjobin gjobin closed this as completed Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats Priority: Low Status: Non Issue Non-Issue. No Action Needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TRaSH- @gjobin @bakerboy448