Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set behaviour if API call fails #8

Open
TTitcombe opened this issue Sep 15, 2021 · 0 comments
Open

Set behaviour if API call fails #8

TTitcombe opened this issue Sep 15, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@TTitcombe
Copy link
Owner

Currently a failed API call will produce unhandled errors. This should be handled by Greta and the user should be able to decide what to do in this scenario. A choice of do/do not run if API call fails.

For this task, treat all failures together (i.e. do not differentiate 4xx and 5xx subtypes). Add a parameter to checks functions to change this behaviour and give it a sensible default (with argument why that should be default behaviour - I've not made up my mind which way!)
@TTitcombe TTitcombe added enhancement New feature or request good first issue Good for newcomers labels Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TTitcombe