User Details don't always match the exact user

[nerdsupremacist]

See Ticket #880490

So far we get the user details by a search with the exact name and filter the list a bit afaik. Perhaps tinker with the filtering a bit or try to fetch it from the LRZ id.

[mammuth]

Tickets:
https://tca.exgen.io/scp/tickets.php?id=213

[arisun]

I would like to contribute on this project. Could you please help picking the first issue to resolve.

[nerdsupremacist]

@arisun if you want you can take a look at this very issue. The reason we haven't gotten around to it is that it will take a bit of reverse engineering of the TumOnline API.

The reason this happens is we search for a user with the exact name of the logged in user and show their details. This obviously leads to conflicts, because you guessed it 2 people can have the same name.

Option 1: see if we can get a hold on the LRZ ids of the search results and only match the ones with the exact same LRZ Id as the logged in user. Instead of blindly taking the first one.
Option 2: check if there's another endpoint we can request for this.

The relevant files are:

https://github.com/TCA-Team/iOS/blob/master/TUM%20Campus%20App/UserDataManager.swift
https://github.com/TCA-Team/iOS/blob/master/TUM%20Campus%20App/PersonSearchManager.swift

[arisun]

@mathiasquintero do you have any mock data (LRZ ID) for login, so I can check.

[nerdsupremacist]

@arisun wait, you're not a student? Ok. This is gonna be difficult. @mammuth how are we handling cases like this? Didn't we have an ID for Apple to log in?

[kordianbruck]

Unfortunately there are no test users. But alumnis can still login into tumonline and use the app

[kordianbruck]

https://tca.exgen.io/scp/tickets.php?id=264

[kordianbruck]

@mathiasquintero is there any solution for this. We are getting many support tickets mentioning this issue, which does not really seem that problematic to me to resolve it? Or is it?

[nerdsupremacist]

@kordianbruck Ok. Do you know exactly what Android is doing in this use case. Or are they having the same issue as well?

Since the data that we get from searching is not enough to pin down which user we want we might need a /me endpoint. Do we know if it exists?

[kordianbruck]

@pfent ?

[pfent]

Ah, thanks for pinging me, I could had clearified this much earlier.
For starters I'd suggest to not guessing the names, when there's no exact match 👻

I think for the exact name you can just use the id endpoint and show that name to the user.

To get the person details, we search for the person like you do, but only if we get a unique match, we actually display the picture of the user.
You could also manually filter out users, that no not have the exact searched name, but I couldn't be bothered to implement that, yet.

@xsrf @kordianbruck a TUMonline endpoint to get the own pIdentNr for the personsearch would be awesome

[nerdsupremacist]

Ok. For now I just won't set any attribute other than the name if there's more than one result.