Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pipfile #1

Closed
kiview opened this issue Jun 5, 2021 · 3 comments
Closed

Add Pipfile #1

kiview opened this issue Jun 5, 2021 · 3 comments

Comments

@kiview
Copy link

kiview commented Jun 5, 2021

In order to make the build easily reproducible for others, I'd recommend adding something like pipenv.

If you give me the list of required packages (only some Hue package?), I'd be happy to raise a PR and also add a CI job for building the exe. What did you use for building the distributable?

@TUnbehaun
Copy link
Owner

This is a great idea! I am using a venv locally and was kind of in rush when creating the repo yesterday, so I just uploaded the main files without the dependencies. And I was also planning to make the build process and especially the distributable more transparent.

The pip packages required are:

  • phue
  • PySimpleGui

For building the distributable I used PyInstaller.

Thanks a lot for your help! Much appreciated.

@TUnbehaun
Copy link
Owner

Added the two dependencies (phue, PySimpleGui) as .py files directly to the repo under /external and created a GitHub Action that automatically builds and releases the app.

@kiview
Copy link
Author

kiview commented Jul 2, 2021

Note that you should reference the MIT license of the original files, just to be safe 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants