Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overcomplex callaback scheme in the React UI #92

Open
jamesyoungman opened this issue Jun 12, 2022 · 0 comments
Open

Fix overcomplex callaback scheme in the React UI #92

jamesyoungman opened this issue Jun 12, 2022 · 0 comments
Labels
help wanted Extra attention is needed Web Web UI issues

Comments

@jamesyoungman
Copy link
Contributor

In tx2-web/src/AlarmPanel.tsx there are callbacks into controller/alarm.ts, and also callbacks in the opposite direction. With a callback registry.

There is a similar picture between tx2-web/src/IoPanel.tsx and controller/io.ts.

This seems more complex than necessary. Someone more experienced with React than I am can likely suggest a simpler approach.
@jamesyoungman jamesyoungman added help wanted Extra attention is needed Web Web UI issues labels Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed Web Web UI issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jamesyoungman