Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge information about Gerrit, reviewing / testing patches and improving patches #96

Closed
1 task
sypets opened this issue Oct 7, 2018 · 0 comments · Fixed by #97
Closed
1 task

Merge information about Gerrit, reviewing / testing patches and improving patches #96

sypets opened this issue Oct 7, 2018 · 0 comments · Fixed by #97

Comments

@sypets
Copy link
Contributor

sypets commented Oct 7, 2018

Currently, there is some overlap of information, specifically in:

This information could be merged into one chapter and duplicate information removed.

Additionally, the page on Gerrit might be changed to be more consistent with the rest of the guide, specifically:

  • The rest of the guide is structured in a way that the information is supplied in the order that a contributor needs it. In the case of the Gerrit chapter, it contains a lot of info on reviewing a patch, which most likely will be done after someone submits a patch. Currently the reader is confronted with a lot of details before he needs it. Most likely, they just want to create a patch. So it is probably better to move this chapter to after "Fixing a bug"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant