Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sliding Window Pagination example is wrong #4164

Open
cweiske opened this issue Mar 11, 2024 · 2 comments
Open

Sliding Window Pagination example is wrong #4164

cweiske opened this issue Mar 11, 2024 · 2 comments

Comments

@cweiske
Copy link
Contributor

cweiske commented Mar 11, 2024

Current behavior

https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Pagination/Index.html

The "sliding window pagination" docs say:

Example: Imagine 1000 records and 20 items per page which would lead to 50 links. Using the SlidingWindowPagination, you will get something like < 1 2 ... 21 22 23 24 ... 100 >.

This is not correct. The pagination will only give you "21 22 23 24", but not 1, 2, "..." and 100.

Expected behavior/output

The example needs to be corrected or the example code adjusted, so that "< 1 2 ..." are generated by its output.

Links

TYPO3 versions

main, 12

@linawolf
Copy link
Member

@cweiske , thanks for reporting it. Wouldnt the actual output depend on the templates used? The exact output example is mentioned like that in changelog that you cite?

@cweiske
Copy link
Contributor Author

cweiske commented Apr 28, 2024

The template only renders the links that the pagination creates.
I think the changelog is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants