[BUGFIX] Initialize TSFE, if conf of page was cached #2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With first call of getConfigurationFromPageId() the parameter initializeTsfe is checked and processed. With a second call to getConfigurationFromPageId() we now check, if TSFE has to be initialized also while retrieving data from cache. Resolves: TYPO3-Solr#2150
|
Please do not merge...I will try to add a UnitTest first... |
|
Stumbled over this, too. But in my case it is the second level cache. If $initializeTsfe is true and there is a hit in the second level cache, TSFE needs to get initialized, too. Will add an additional issue and PR |
Mabahe
added a commit
to Mabahe/ext-solr
that referenced
this pull request
Jul 4, 2019
In addition to TYPO3-Solr#2323 TSFE needs to get a proper initialization also on a TwoLevelCache hit. Otherwise you get different TSFE objects when indexing records via additionalPageIds outside the normal page tree for the first indexing (without TwoLevelCache hit) and second indexing (with TwoLevelCache hit). Resolves: TYPO3-Solr#2328
Mabahe
added a commit
to Mabahe/ext-solr
that referenced
this pull request
Jul 4, 2019
In addition to TYPO3-Solr#2323 TSFE needs to get a proper initialization also on a TwoLevelCache hit. Otherwise you get different TSFE objects when indexing records via additionalPageIds outside the normal page tree for the first indexing (without TwoLevelCache hit) and second indexing (with TwoLevelCache hit). Resolves: TYPO3-Solr#2328
This was referenced Jul 4, 2019
timohund
pushed a commit
that referenced
this pull request
Sep 2, 2019
In addition to #2323 TSFE needs to get a proper initialization also on a TwoLevelCache hit. Otherwise you get different TSFE objects when indexing records via additionalPageIds outside the normal page tree for the first indexing (without TwoLevelCache hit) and second indexing (with TwoLevelCache hit). Resolves: #2328
timohund
pushed a commit
that referenced
this pull request
Sep 2, 2019
In addition to #2323 TSFE needs to get a proper initialization also on a TwoLevelCache hit. Otherwise you get different TSFE objects when indexing records via additionalPageIds outside the normal page tree for the first indexing (without TwoLevelCache hit) and second indexing (with TwoLevelCache hit). Resolves: #2328
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Mar 1, 2021
* Removes `Integration\UtilTest::getConfigurationFromPageIdInitializesTsfeOnCacheCall` in favor of `Unit\IndexQueue\IndexerTest::indexerAlwaysInitializesTSFE` The TSFE-initialization was moved and refactored from `Util` to `FrontendEnvironment` which is used in Indexer directly. Related: TYPO3-Solr#2323, TYPO3-Solr#2150, TYPO3-Solr#2303 Fixes: TYPO3-Solr#2862
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Mar 7, 2021
* Removes `Integration\UtilTest::getConfigurationFromPageIdInitializesTsfeOnCacheCall` in favor of `Unit\IndexQueue\IndexerTest::indexerAlwaysInitializesTSFE` The TSFE-initialization was moved and refactored from `Util` to `FrontendEnvironment` which is used in Indexer directly. Related: TYPO3-Solr#2323, TYPO3-Solr#2150, TYPO3-Solr#2303 Fixes: TYPO3-Solr#2862
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Mar 7, 2021
… TYPO3 API * Removes `Integration\UtilTest::getConfigurationFromPageIdInitializesTsfeOnCacheCall` in favor of `Unit\IndexQueue\IndexerTest::indexerAlwaysInitializesTSFE` The TSFE-initialization was moved and refactored from `Util` to `FrontendEnvironment` which is used in Indexer directly. Related: TYPO3-Solr#2323, TYPO3-Solr#2150, TYPO3-Solr#2303 Fixes: TYPO3-Solr#2862
dkd-kaehm
added a commit
that referenced
this pull request
Mar 8, 2021
* Removes `Integration\UtilTest::getConfigurationFromPageIdInitializesTsfeOnCacheCall` in favor of `Unit\IndexQueue\IndexerTest::indexerAlwaysInitializesTSFE` The TSFE-initialization was moved and refactored from `Util` to `FrontendEnvironment` which is used in Indexer directly. Related: #2323, #2150, #2303 Fixes: #2862
dkd-kaehm
added a commit
that referenced
this pull request
Mar 8, 2021
… TYPO3 API * Removes `Integration\UtilTest::getConfigurationFromPageIdInitializesTsfeOnCacheCall` in favor of `Unit\IndexQueue\IndexerTest::indexerAlwaysInitializesTSFE` The TSFE-initialization was moved and refactored from `Util` to `FrontendEnvironment` which is used in Indexer directly. Related: #2323, #2150, #2303 Fixes: #2862
dkd-kaehm
added a commit
that referenced
this pull request
Oct 8, 2021
… TYPO3 API * Removes `Integration\UtilTest::getConfigurationFromPageIdInitializesTsfeOnCacheCall` in favor of `Unit\IndexQueue\IndexerTest::indexerAlwaysInitializesTSFE` The TSFE-initialization was moved and refactored from `Util` to `FrontendEnvironment` which is used in Indexer directly. Related: #2323, #2150, #2303 Fixes: #2862
dkd-kaehm
added a commit
that referenced
this pull request
Oct 8, 2021
… TYPO3 API * Removes `Integration\UtilTest::getConfigurationFromPageIdInitializesTsfeOnCacheCall` in favor of `Unit\IndexQueue\IndexerTest::indexerAlwaysInitializesTSFE` The TSFE-initialization was moved and refactored from `Util` to `FrontendEnvironment` which is used in Indexer directly. Related: #2323, #2150, #2303 Fixes: #2862
dkd-kaehm
added a commit
that referenced
this pull request
Oct 8, 2021
… TYPO3 API * Removes `Integration\UtilTest::getConfigurationFromPageIdInitializesTsfeOnCacheCall` in favor of `Unit\IndexQueue\IndexerTest::indexerAlwaysInitializesTSFE` The TSFE-initialization was moved and refactored from `Util` to `FrontendEnvironment` which is used in Indexer directly. Related: #2323, #2150, #2303 Fixes: #2862
dkd-kaehm
added a commit
that referenced
this pull request
Oct 8, 2021
… TYPO3 API * Removes `Integration\UtilTest::getConfigurationFromPageIdInitializesTsfeOnCacheCall` in favor of `Unit\IndexQueue\IndexerTest::indexerAlwaysInitializesTSFE` The TSFE-initialization was moved and refactored from `Util` to `FrontendEnvironment` which is used in Indexer directly. Related: #2323, #2150, #2303 Fixes: #2862
dkd-kaehm
added a commit
that referenced
this pull request
Oct 8, 2021
… TYPO3 API * Removes `Integration\UtilTest::getConfigurationFromPageIdInitializesTsfeOnCacheCall` in favor of `Unit\IndexQueue\IndexerTest::indexerAlwaysInitializesTSFE` The TSFE-initialization was moved and refactored from `Util` to `FrontendEnvironment` which is used in Indexer directly. Related: #2323, #2150, #2303 Fixes: #2862
dkd-kaehm
added a commit
that referenced
this pull request
Oct 8, 2021
… TYPO3 API * Removes `Integration\UtilTest::getConfigurationFromPageIdInitializesTsfeOnCacheCall` in favor of `Unit\IndexQueue\IndexerTest::indexerAlwaysInitializesTSFE` The TSFE-initialization was moved and refactored from `Util` to `FrontendEnvironment` which is used in Indexer directly. Related: #2323, #2150, #2303 Fixes: #2862
dkd-kaehm
added a commit
that referenced
this pull request
Oct 8, 2021
… TYPO3 API * Removes `Integration\UtilTest::getConfigurationFromPageIdInitializesTsfeOnCacheCall` in favor of `Unit\IndexQueue\IndexerTest::indexerAlwaysInitializesTSFE` The TSFE-initialization was moved and refactored from `Util` to `FrontendEnvironment` which is used in Indexer directly. Related: #2323, #2150, #2303 Fixes: #2862
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Dec 2, 2021
… TYPO3 API * Removes `Integration\UtilTest::getConfigurationFromPageIdInitializesTsfeOnCacheCall` in favor of `Unit\IndexQueue\IndexerTest::indexerAlwaysInitializesTSFE` The TSFE-initialization was moved and refactored from `Util` to `FrontendEnvironment` which is used in Indexer directly. Related: TYPO3-Solr#2323, TYPO3-Solr#2150, TYPO3-Solr#2303 Fixes: TYPO3-Solr#2862
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With first call of getConfigurationFromPageId()
the parameter initializeTsfe is checked and processed.
With a second call to getConfigurationFromPageId()
we now check, if TSFE has to be initialized also while
retrieving data from cache.
Resolves: #2150
What this pr does
It initializes TSFE also, if configuration was fetched from configurationObjectCache
How to test
A perfect instruction you can find here: #2150
Fixes: #2150