[BUGFIX] Drop "LIVE workspace" tab from workspace module

The "LIVE workspace" tab of the workspace module always
showed wrong records from other workspaces. This issue
has been resolved with the pid=-1 removal in v10.

Since then, this tab never shows records. The patch
removes the tab from the interface. Users, including
admins, now see a "Please select a workspace first"
message when calling the module in online / live
workspace.

Resolves: #91983
Related: #89122
Related: #13056
Releases: master, 10.4
Change-Id: Ib1029253d53745d82786f31276283e5f88ebf9b4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65284
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Achim Fritz <af@achimfritz.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>

typo3/sysext/workspaces/Classes/Controller/ReviewController.php

@@ -179,7 +179,7 @@ public function indexAction()
         $this->pageRenderer->addInlineSetting('Workspaces', 'isLiveWorkspace', (int)$backendUser->workspace === 0);
         $this->pageRenderer->addInlineSetting('Workspaces', 'workspaceTabs', $this->prepareWorkspaceTabs($wsList, $activeWorkspace));
         $this->pageRenderer->addInlineSetting('Workspaces', 'activeWorkspaceId', $activeWorkspace);
-        $workspaceIsAccessible = !($backendUser->workspace === 0 && !$backendUser->isAdmin());
+        $workspaceIsAccessible = $backendUser->workspace !== WorkspaceService::LIVE_WORKSPACE_ID;
         $this->view->assignMultiple([
             'showGrid' => $workspaceIsAccessible,
             'showLegend' => $workspaceIsAccessible,
@@ -265,7 +265,9 @@ protected function prepareWorkspaceTabs(array $workspaceList, int $activeWorkspa
     {
         $tabs = [];
 
-        if ($activeWorkspace !== WorkspaceService::SELECT_ALL_WORKSPACES) {
+        if ($activeWorkspace !== WorkspaceService::SELECT_ALL_WORKSPACES
+            && $activeWorkspace !== WorkspaceService::LIVE_WORKSPACE_ID
+        ) {
             $tabs[] = [
                 'title' => $workspaceList[$activeWorkspace],
                 'itemId' => 'workspace-' . $activeWorkspace,
@@ -284,7 +286,9 @@ protected function prepareWorkspaceTabs(array $workspaceList, int $activeWorkspa
         }
 
         foreach ($workspaceList as $workspaceId => $workspaceTitle) {
-            if ($workspaceId === $activeWorkspace) {
+            if ($workspaceId === $activeWorkspace
+                || $workspaceId === WorkspaceService::LIVE_WORKSPACE_ID
+            ) {
                 continue;
             }
             $tabs[] = [