Skip to content

Commit

Permalink
[TASK] Improve MFA labels
Browse files Browse the repository at this point in the history 
This improves some MFA labels and fixes some typos.

Resolves: #93657
Releases: master
Change-Id: I0078e606d90aebdd3110c4a753170180d2870f8c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68190
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
  • Loading branch information
@o-ba @lolli42
o-ba authored and lolli42 committed Mar 8, 2021
1 parent 121812e commit 5db2a9d
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 13 deletions.
4 changes: 2 additions & 2 deletions typo3/sysext/backend/Resources/Private/Language/locallang_mfa.xlf
View file
Expand Up @@ -130,7 +130,7 @@
<source>Successfully updated MFA provider %s.</source>
</trans-unit>
<trans-unit id="auth.authError" resname="auth.authError">
<source>Authentication was not succesful</source>
<source>Authentication was not successful.</source>
</trans-unit>
<trans-unit id="auth.submit" resname="auth.submit">
<source>Verify</source>
Expand Down Expand Up @@ -160,7 +160,7 @@
<source>Your are not allowed to perfom this action</source>
</trans-unit>
<trans-unit id="ajax.deactivate.providersNotDeactivated">
<source>No provider was deactivated</source>
<source>No provider has been deactivated</source>
</trans-unit>
<trans-unit id="ajax.deactivate.providersDeactivated">
<source>Successfully deactivated all active providers for user %s</source>
Expand Down
17 changes: 10 additions & 7 deletions typo3/sysext/core/Resources/Private/Language/locallang_mfa_provider.xlf
View file
Expand Up @@ -8,24 +8,24 @@
</trans-unit>
<trans-unit id="totp.description" resname="totp.description">
<source>This provider allows to authenticate with a single-use passcode which is based on the current time.
Each code is only valid for 30 seconds. You need a OTP application supporting such tokens.</source>
Each code is only valid for 30 seconds. You need a OTP application or device, supporting such tokens.</source>
</trans-unit>
<trans-unit id="totp.setupInstructions" resname="totp.setupInstructions">
<source>The time-based one-time password provider enables you to strengthen your accounts' security by requiring a six-digit code on every login.
This provider is based on a shared secret, which will be exchanged between your OTP application (or device) and TYPO3. Each code takes the current time into account and is only valid for 30 seconds.

Setting up:
1. Scan the QR-code or directly enter the shared secret in your application or device
2. Enter the generated six-digit code in the corresponding field
3. Add a specific name for this provider (optional)
2. Add a specific name for this provider (optional)
3. Enter the generated six-digit code in the corresponding field
4. Submit the form to activate the provider</source>
</trans-unit>
<trans-unit id="recoveryCodes.title" resname="recoveryCodes.title">
<source>Recovery codes</source>
</trans-unit>
<trans-unit id="recoveryCodes.description" resname="recoveryCodes.description">
<source>This provider allows to authenticate with a set of single-use passcodes, in case you lost your
primary MFA credentials, or just have no access to them currently.</source>
primary MFA credentials, or just have no access to them temporarily.</source>
</trans-unit>
<trans-unit id="recoveryCodes.setupInstructions" resname="recoveryCodes.setupInstructions">
<source>Recovery codes are random eight-digit codes which can be used to authenticate, in case your lost your main authentication credentials. Each code is only valid once.
Expand All @@ -39,7 +39,7 @@
Note: Since the recovery codes are being encrypted and stored securely, this process can take some time.</source>
</trans-unit>
<trans-unit id="totpInputLabel" resname="totpInputLabel">
<source>Enter the six-digit code</source>
<source>Enter the generated six-digit code</source>
</trans-unit>
<trans-unit id="totpInputHelp" resname="totpInputHelp">
<source>This code should now be displayed on your device or in your application.</source>
Expand Down Expand Up @@ -108,7 +108,7 @@
<source>Copy the shared secret</source>
</trans-unit>
<trans-unit id="setup.secret.help" resname="setup.secret.help">
<source>You can also enter the shared secret manually in your OTP device or application.</source>
<source>You can also enter the shared secret manually in your OTP application or device.</source>
</trans-unit>
<trans-unit id="setup.name.label" resname="setup.name.label">
<source>Enter a name (optional)</source>
Expand All @@ -134,9 +134,12 @@
<trans-unit id="setup.recoveryCodes.noActiveProviders.message" resname="setup.recoveryCodes.noActiveProviders.message">
<source>
Recovery codes are only meant as a fallback if you lose access to your main multi-factor
authentication credentials. Therefore, please active a comprehensive MFA provider first.
authentication credentials. Therefore, please activate a comprehensive MFA provider first.
</source>
</trans-unit>
<trans-unit id="auth.totp.inputLabel" resname="auth.totp.inputLabel">
<source>Enter the six-digit code</source>
</trans-unit>
<trans-unit id="auth.recoveryCodes.inputLabel" resname="auth.recoveryCodes.inputLabel">
<source>Enter an eight-digit recovery code</source>
</trans-unit>
Expand Down
2 changes: 1 addition & 1 deletion typo3/sysext/core/Resources/Private/Templates/Authentication/MfaProvider/Totp/Auth.html
View file
Expand Up @@ -9,7 +9,7 @@
<div class="form-control-wrap">
<div class="form-control-holder">
<div class="form-control-clearable form-control">
<input type="text" id="totp" class="form-control input-login" name="totp" value="" autofocus="autofocus" required="required" maxlength="6" minlength="6" pattern="[0-9]+" aria-label="{f:translate(key: 'LLL:EXT:core/Resources/Private/Language/locallang_mfa_provider.xlf:totpInputLabel')}" placeholder="{f:translate(key: 'LLL:EXT:core/Resources/Private/Language/locallang_mfa_provider.xlf:totpInputLabel')}"/>
<input type="text" id="totp" class="form-control input-login" name="totp" value="" autofocus="autofocus" required="required" maxlength="6" minlength="6" pattern="[0-9]+" aria-label="{f:translate(key: 'LLL:EXT:core/Resources/Private/Language/locallang_mfa_provider.xlf:auth.totp.inputLabel')}" placeholder="{f:translate(key: 'LLL:EXT:core/Resources/Private/Language/locallang_mfa_provider.xlf:auth.totp.inputLabel')}"/>
</div>
</div>
</div>
Expand Down
6 changes: 3 additions & 3 deletions typo3/sysext/setup/Resources/Private/Language/locallang.xlf
View file
Expand Up @@ -322,10 +322,10 @@
<source>Account security</source>
</trans-unit>
<trans-unit id="mfaProviders" resname="mfaProviders">
<source>Multi-factor authentication providers</source>
<source>Multi-factor authentication</source>
</trans-unit>
<trans-unit id="mfaProviders.notAvailable" resname="mfaProviders.notAvailable">
<source>Currently no multi-factor authentication providers are available.</source>
<source>Multi-factor authentication is currently not available.</source>
</trans-unit>
<trans-unit id="mfaProviders.description" resname="mfaProviders.description">
<source>Use multi-factor authentication to secure your account by providing another factor next to your password.</source>
Expand All @@ -340,7 +340,7 @@
<source>Setup multi-factor authentication</source>
</trans-unit>
<trans-unit id="mfaProviders.manageLinkTitle" resname="mfaProviders.manageLinkTitle">
<source>Manage your MFA providers</source>
<source>Manage multi-factor authentication</source>
</trans-unit>
<trans-unit id="setupWasUpdated" resname="setupWasUpdated">
<source>User settings were updated.</source>
Expand Down

0 comments on commit 5db2a9d

Please sign in to comment.