Skip to content

Commit

Permalink
Revert "[BUGFIX] Allow to send multiple HTTP headers with the same name"
Browse files Browse the repository at this point in the history
This reverts commit 1683f10.

Reason for revert:
This breaks existing code, as multiple headers are now
sent to the client which were previously overridden.

As long as there is existing code in TYPO3 where header() is
sent, this change can only be done as a breaking change.

Change-Id: Id7444b1455855702143b3fde5629203f252ba07e
Reverts: #88420
Resolves: #88457
Releases: master, 9.5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60874
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
  • Loading branch information
bmack committed Jun 4, 2019
1 parent e7df51d commit 7791461
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions typo3/sysext/core/Classes/Http/AbstractApplication.php
Expand Up @@ -74,9 +74,7 @@ protected function sendResponse(ResponseInterface $response)
}

foreach ($response->getHeaders() as $name => $values) {
foreach ($values as $value) {
header($name . ': ' . $value, false);
}
header($name . ': ' . implode(', ', $values));
}
}
$body = $response->getBody();
Expand Down

0 comments on commit 7791461

Please sign in to comment.