Skip to content

Commit

Permalink
[BUGFIX] Drop unused DataHandler::printLogErrorMessages() argument
Browse files Browse the repository at this point in the history
The argument can be safely dropped since it is not used in the
method anyways.

Resolves: #83333
Related: #82629
Releases: 8.7
Change-Id: I7ede9c58f454d887d9313163988a50c8b31d9846
Reviewed-on: https://review.typo3.org/55078
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
  • Loading branch information
mbrodala authored and liayn committed Dec 14, 2017
1 parent 07bfe63 commit 82482db
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ public function processData()
$this->previewData['table'] = $table;
$this->previewData['id'] = $id;
}
$tce->printLogErrorMessages(isset($_POST['_saveandclosedok']) || isset($_POST['_translation_savedok']) ? $this->retUrl : $this->R_URL_parts['path'] . '?' . GeneralUtility::implodeArrayForUrl('', $this->R_URL_getvars));
$tce->printLogErrorMessages();
}
// || count($tce->substNEWwithIDs)... If any new items has been save, the document is CLOSED
// because if not, we just get that element re-listed as new. And we don't want that!
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ public function mainAction(ServerRequestInterface $request, ResponseInterface $r

// Write errors to flash message queue
if ($this->prErr) {
$this->tce->printLogErrorMessages($this->redirect);
$this->tce->printLogErrorMessages();
}
if ($this->redirect) {
$response = $response
Expand Down Expand Up @@ -259,7 +259,7 @@ public function processAjaxRequest(ServerRequestInterface $request, ResponseInte
// Prints errors (= write them to the message queue)
if ($this->prErr) {
$content['hasErrors'] = true;
$this->tce->printLogErrorMessages($this->redirect);
$this->tce->printLogErrorMessages();
}

$messages = $flashMessageService->getMessageQueueByIdentifier()->getAllMessagesAndFlush();
Expand Down
4 changes: 1 addition & 3 deletions typo3/sysext/core/Classes/DataHandling/DataHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -8803,10 +8803,8 @@ public function newlog2($message, $table, $uid, $pid = null, $error = 0)

/**
* Print log error messages from the operations of this script instance
*
* @param string $redirect Redirect URL (for creating link in message)
*/
public function printLogErrorMessages($redirect)
public function printLogErrorMessages()
{
$queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)->getQueryBuilderForTable('sys_log');
$queryBuilder->getRestrictions()->removeAll();
Expand Down
2 changes: 1 addition & 1 deletion typo3/sysext/recordlist/Classes/RecordList.php
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ public function main()
if (isset($cmd['pages'])) {
BackendUtility::setUpdateSignal('updatePageTree');
}
$tce->printLogErrorMessages(GeneralUtility::getIndpEnv('REQUEST_URI'));
$tce->printLogErrorMessages();
}
}
// Initialize the listing object, dblist, for rendering the list:
Expand Down

0 comments on commit 82482db

Please sign in to comment.