Skip to content

Commit

Permalink
[BUGFIX] Avoid PHP warning when using Phar archive with open_basedir
Browse files Browse the repository at this point in the history
Including files from Phar archives (e.g. "phar://file.phar/autoload.php")
does not work properly with having PHP setting open_basedir defined. The
reason for that is, that TYPO3's custom PharStreamWrapper tries to find
the appropriate base Phar file using file_exists() calls internally. In
case those files are not part of the open_basedir restriction - which is
the case for everything prefixed with the "phar://" scheme - a PHP
warning is shown.

Resolves: #85547
Releases: master, 8.7, 7.6
Change-Id: I72fdd7f0c016c0a8b1ed56a82b6b4042cac4d930
Reviewed-on: https://review.typo3.org/57587
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
  • Loading branch information
ohader authored and lolli42 committed Jul 13, 2018
1 parent 4003c5f commit 9b3b4de
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion typo3/sysext/core/Classes/IO/PharStreamWrapper.php
Expand Up @@ -472,7 +472,7 @@ protected function determineBaseFile(string $path)

while (count($parts)) {
$currentPath = implode('/', $parts);
if (file_exists($currentPath)) {
if (@file_exists($currentPath)) {
return $currentPath;
}
array_pop($parts);
Expand Down

0 comments on commit 9b3b4de

Please sign in to comment.