-
Notifications
You must be signed in to change notification settings - Fork 639
/
MethodArgumentDroppedStaticMatcherTest.php
254 lines (244 loc) · 8.48 KB
/
MethodArgumentDroppedStaticMatcherTest.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
<?php
declare(strict_types = 1);
namespace TYPO3\CMS\Install\Tests\Unit\ExtensionScanner\Php\Matcher;
/*
* This file is part of the TYPO3 CMS project.
*
* It is free software; you can redistribute it and/or modify it under
* the terms of the GNU General Public License, either version 2
* of the License, or any later version.
*
* For the full copyright and license information, please read the
* LICENSE.txt file that was distributed with this source code.
*
* The TYPO3 project - inspiring people to share!
*/
use PhpParser\NodeTraverser;
use PhpParser\NodeVisitor\NameResolver;
use PhpParser\ParserFactory;
use TYPO3\CMS\Install\ExtensionScanner\Php\Matcher\MethodArgumentDroppedStaticMatcher;
use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
/**
* Test case
*/
class MethodArgumentDroppedStaticMatcherTest extends UnitTestCase
{
/**
* @test
*/
public function hitsFromFixtureAreFound()
{
$parser = (new ParserFactory())->create(ParserFactory::PREFER_PHP7);
$fixtureFile = __DIR__ . '/Fixtures/MethodArgumentDroppedStaticMatcherFixture.php';
$statements = $parser->parse(file_get_contents($fixtureFile));
$traverser = new NodeTraverser();
$traverser->addVisitor(new NameResolver());
$configuration = [
'TYPO3\CMS\Core\Utility\GeneralUtility::getFileAbsFileName' => [
'maximumNumberOfArguments' => 1,
'restFiles' => [
'Breaking-80700-DeprecatedFunctionalityRemoved.rst',
'Deprecation-73516-VariousGeneralUtilityMethods.rst'
],
],
];
$subject = new MethodArgumentDroppedStaticMatcher($configuration);
$traverser->addVisitor($subject);
$traverser->traverse($statements);
$expectedHitLineNumbers = [
28,
30,
32,
];
$actualHitLineNumbers = [];
foreach ($subject->getMatches() as $hit) {
$actualHitLineNumbers[] = $hit['line'];
}
$this->assertEquals($expectedHitLineNumbers, $actualHitLineNumbers);
}
/**
* @return array
*/
public function matchesReturnsExpectedRestFilesDataProvider(): array
{
return [
'two rest candidates with same number of arguments' => [
[
'Foo::aMethod' => [
'maximumNumberOfArguments' => 0,
'restFiles' => [
'Foo-1.rst',
'Foo-2.rst',
],
],
'Bar::aMethod' => [
'maximumNumberOfArguments' => 0,
'restFiles' => [
'Bar-1.rst',
'Bar-2.rst',
],
],
],
'<?php
$someVar::aMethod(\'foo\');',
[
0 => [
'restFiles' => [
'Foo-1.rst',
'Foo-2.rst',
'Bar-1.rst',
'Bar-2.rst',
],
],
],
],
'two candidates, only one hits because second candidate needs one argument' => [
[
'Foo::aMethod' => [
'maximumNumberOfArguments' => 2,
'restFiles' => [
'Foo-1.rst',
],
],
'Bar::aMethod' => [
'maximumNumberOfArguments' => 3,
'restFiles' => [
'Bar-1.rst',
],
],
],
'<?php
$someVar::aMethod(\'arg1\', \'arg2\', \'arg3\');',
[
0 => [
'restFiles' => [
'Foo-1.rst',
],
],
],
],
'three candidates, first and second hits' => [
[
'Foo::aMethod' => [
'maximumNumberOfArguments' => 0,
'restFiles' => [
'Foo-1.rst',
],
],
'Bar::aMethod' => [
'maximumNumberOfArguments' => 1,
'restFiles' => [
'Bar-1.rst',
],
],
'FooBar::aMethod' => [
'maximumNumberOfArguments' => 2,
'restFiles' => [
'FooBar-1.rst',
],
],
],
'<?php
$someVar::aMethod(\'arg1\', \'arg2\');',
[
0 => [
'restFiles' => [
'Foo-1.rst',
'Bar-1.rst',
],
],
],
],
'one candidate, does not hit, not enough arguments given' => [
[
'Foo::aMethod' => [
'maximumNumberOfArguments' => 1,
'restFiles' => [
'Foo-1.rst',
],
],
],
'<?php
$someVar::aMethod();',
[], // no hit
],
'no match, method call using argument unpacking' => [
[
'Foo::aMethod' => [
'maximumNumberOfArguments' => 2,
'restFiles' => [
'Foo-1.rst',
],
],
],
'<?php
$args = [\'arg1\', \'arg2\', \'arg3\'];
$someVar::aMethod(...$args);',
[],
],
'method call using argument unpacking with more than max number of args given arguments' => [
[
'Foo::aMethod' => [
'maximumNumberOfArguments' => 2,
'restFiles' => [
'Foo-1.rst',
],
],
],
'<?php
$args1 = [\'arg1\', \'arg2\', \'arg3\'];
$args2 = [\'arg4\', \'arg5\', \'arg6\'];
$args3 = [\'arg7\', \'arg8\', \'arg9\'];
$someVar::aMethod(...$args1, ...$args2, ...$args3);',
[],
],
'double linked .rst file is returned only once' => [
[
'Foo::aMethod' => [
'maximumNumberOfArguments' => 0,
'restFiles' => [
'aRest.rst',
],
],
'Bar::aMethod' => [
'maximumNumberOfArguments' => 0,
'restFiles' => [
'aRest.rst',
],
],
],
'<?php
$someVar::aMethod(\'foo\');',
[
0 => [
'restFiles' => [
'aRest.rst',
],
],
],
],
];
}
/**
* @test
* @dataProvider matchesReturnsExpectedRestFilesDataProvider
* @param array $configuration
* @param string $phpCode
* @param array $expected
*/
public function matchesReturnsExpectedRestFiles(array $configuration, string $phpCode, array $expected)
{
$parser = (new ParserFactory())->create(ParserFactory::ONLY_PHP7);
$statements = $parser->parse($phpCode);
$subject = new MethodArgumentDroppedStaticMatcher($configuration);
$traverser = new NodeTraverser();
$traverser->addVisitor($subject);
$traverser->traverse($statements);
$result = $subject->getMatches();
if (isset($expected[0], $result[0])) {
$this->assertEquals($expected[0]['restFiles'], $result[0]['restFiles']);
} else {
$this->assertEquals($expected, $result);
}
}
}