Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add num_cpus crate #71

Merged
merged 1 commit into from May 14, 2021
Merged

Add num_cpus crate #71

merged 1 commit into from May 14, 2021

Conversation

citizen428
Copy link
Contributor

This PR replaces the custom code for finding the number of available CPU cores with the num_cpus crate. This should get us a little closer to Windows support as the current code did not take Windows into account. I plan to eventually also look into other Windows-related problems even though my main development OS is Linux.

changelog:

  • Add num_cpus crate

@TaKO8Ki
Copy link
Owner

TaKO8Ki commented May 12, 2021

@citizen428
Thank you for your contribution! The error CI causes have nothing to do with this PR. So, please ignore it.

@TaKO8Ki
Copy link
Owner

TaKO8Ki commented May 12, 2021

@citizen428
I did quick-fix in #72. So, could you rebase upstream/master?

@TaKO8Ki TaKO8Ki self-requested a review May 13, 2021 01:40
Copy link
Owner

@TaKO8Ki TaKO8Ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TaKO8Ki TaKO8Ki merged commit 58e512d into TaKO8Ki:main May 14, 2021
@citizen428 citizen428 deleted the add-num-cpus-crate branch May 17, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants