Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI #52

Open
benjaminoakes opened this issue Dec 16, 2023 · 2 comments
Open

Add CI #52

benjaminoakes opened this issue Dec 16, 2023 · 2 comments

Comments

@benjaminoakes
Copy link
Collaborator

benjaminoakes commented Dec 16, 2023 •
edited

Probably on GitHub Actions because it's free and has a low barrier to entry.

Ideas:

  • Build extension
  • Check style
  • Run automated tests

Related: #51 (review)
@benjaminoakes benjaminoakes mentioned this issue Dec 16, 2023
Merged
@madhur
Copy link
Collaborator

madhur commented Dec 17, 2023

Thats a good idea. Added a basic CI/CD that does following:

Example
https://github.com/TabCarousel/TabCarousel/actions/runs/7236080773/job/19714230840

  • Does npm install
  • Run eslint
  • Creates a zip file of extension

Not sure if you mean publish automatically to chrome store. Not sure if we have API's for that.

@benjaminoakes
Copy link
Collaborator Author

Not sure if you mean publish automatically to chrome store. Not sure if we have API's for that.

I think publishing is manual, as you mentioned. There is some value in ensuring the build step can complete successfully, which is what I meant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjaminoakes @madhur