Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior on resize when cell popup is shown #38

Closed
gurisko opened this issue Dec 29, 2014 · 3 comments
Closed

Behavior on resize when cell popup is shown #38

gurisko opened this issue Dec 29, 2014 · 3 comments

Comments

@gurisko
Copy link
Contributor

gurisko commented Dec 29, 2014

We should discuss what is the expected behavior of the show_cell window when we are resizing the terminal window. If we are going to implement #17 we should not close it because there can be unsaved changes. In this case we should also discuss window size and window placement.

@wavexx
Copy link
Member

wavexx commented Jan 2, 2015

Yes, currently the cell popup might be truncated as well on narrow terminals.
What about doing something different, like drawing a divider at 50% of the terminal height and displaying the content at the bottom without border? This is what tig does when selecting a commit in the graph view (and mutt/etc/...)

@gurisko
Copy link
Contributor Author

gurisko commented Jan 2, 2015

@wavexx I like that idea.

@firecat53
Copy link
Collaborator

Fixed crash on resize with Textbox popup open. 41c0f27. I'm going to go ahead and close this issue. Any text editing issues that arise if we implement editing will be handled with that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants