Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagram: <delete> key deletes the table from the model rather than remove it from the diagram view #139

Closed
zenzeinet opened this issue Jul 19, 2021 · 1 comment
Labels
feature: enhancement Request is a enchacement to existing feature issue: bug Confirmed as a bug in TE3
Milestone

Comments

@zenzeinet
Copy link

zenzeinet commented Jul 19, 2021

Hi,
Do a diagram, add table T1, and then remove it.
If you then do "Add tables" to add T1 again, it does not show in the available tables to add.
Using 3.0.7

EDIT: Just realized that what the "delete" key does in the diagram view is to completely delete the table! (rather than removing it from the diagram, which you do with right-click and then there's no bug).
I would suggest to change this behaviour - it is extremely dangerous and imho counterintuitive (a diagram view is not the place for DDL actions, but for relationship visualization).

(And by the way, if you delete it, and then "undo" the delete, you cannot add it back to the diagram).

I would recommend to please add a confirmation dialog for the deletion of objects, tables, partitions, etc - it can be very dangerous to unwillingly delete things.

I'll leave this bug open, at least if you understand as I do that the "delete" key in a diagram view should remove the table from the diagram, not totally delete it.

@zenzeinet zenzeinet changed the title Diagram: cannot re-add table after removing it Diagram: <delete> key deletes the table from the model rather than remove it from the diagram view Jul 19, 2021
@otykier otykier added feature: enhancement Request is a enchacement to existing feature issue: bug Confirmed as a bug in TE3 labels Aug 4, 2021
@otykier otykier added this to the 3.0.8 milestone Aug 4, 2021
@otykier
Copy link
Collaborator

otykier commented Aug 6, 2021

Fixed in 3.0.8. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: enhancement Request is a enchacement to existing feature issue: bug Confirmed as a bug in TE3
Development

No branches or pull requests

2 participants