fix: avoid nullish coalescing operator

tada5hi · Jan 18, 2023 · 2f98bc1 · 2f98bc1
1 parent 0168e7d
commit 2f98bc1
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 13 deletions.
diff --git a/src/parameter/fields/parse.ts b/src/parameter/fields/parse.ts
@@ -40,7 +40,7 @@ export function parseQueryFields<T extends ObjectLiteral = ObjectLiteral>(
     data: unknown,
     options?: FieldsParseOptions<T>,
 ) : FieldsParseOutput {
-    options ??= {};
+    options = options || {};
 
     const defaultDomainFields = groupArrayByKeyPath(
         flattenParseAllowedOption(options.default),
@@ -85,7 +85,7 @@ export function parseQueryFields<T extends ObjectLiteral = ObjectLiteral>(
         data = { [DEFAULT_ID]: data };
     }
 
-    options.mapping ??= {};
+    options.mapping = options.mapping || {};
     const reverseMapping = buildReverseRecord(options.mapping);
 
     if (keys.length === 0) {

diff --git a/src/parameter/filters/parse.ts b/src/parameter/filters/parse.ts
@@ -107,7 +107,7 @@ export function parseQueryFilters<T extends ObjectLiteral = ObjectLiteral>(
     data: unknown,
     options?: FiltersParseOptions<T>,
 ) : FiltersParseOutput {
-    options = options ?? {};
+    options = options || {};
     options.mapping = options.mapping || {};
     options.relations = options.relations || [];
 

diff --git a/src/parameter/pagination/parse.ts b/src/parameter/pagination/parse.ts
@@ -42,7 +42,7 @@ export function parseQueryPagination(
     data: unknown,
     options?: PaginationParseOptions,
 ) : PaginationParseOutput {
-    options ??= {};
+    options = options || {};
 
     const pagination : PaginationParseOutput = {};
 

diff --git a/src/parameter/relations/parse.ts b/src/parameter/relations/parse.ts
@@ -18,7 +18,7 @@ export function parseQueryRelations<T extends ObjectLiteral = ObjectLiteral>(
     data: unknown,
     options?: RelationsParseOptions<T>,
 ): RelationsParseOutput {
-    options ??= {};
+    options = options || {};
 
     // If it is an empty array nothing is allowed
     if (
@@ -30,7 +30,9 @@ export function parseQueryRelations<T extends ObjectLiteral = ObjectLiteral>(
 
     options.mapping = options.mapping || {};
     options.pathMapping = options.pathMapping || {};
-    options.includeParents ??= true;
+    if (typeof options.includeParents === 'undefined') {
+        options.includeParents = true;
+    }
 
     let items: string[] = [];
 

diff --git a/src/parameter/sort/parse.ts b/src/parameter/sort/parse.ts
@@ -75,7 +75,7 @@ export function parseQuerySort<T extends ObjectLiteral = ObjectLiteral>(
     data: unknown,
     options?: SortParseOptions<T>,
 ) : SortParseOutput {
-    options = options ?? {};
+    options = options || {};
 
     // If it is an empty array nothing is allowed
     if (typeof options.allowed !== 'undefined') {

diff --git a/src/parse/module.ts b/src/parse/module.ts
@@ -21,7 +21,7 @@ export function parseQuery<T extends ObjectLiteral = ObjectLiteral>(
     input: ParseInput,
     options?: ParseOptions<T>,
 ) : ParseOutput {
-    options ??= {};
+    options = options || {};
 
     const mergeWithGlobalOptions = <T extends {[key: string]: any} & {defaultPath?: string} >(data?: T) : T => {
         if (typeof data !== 'undefined') {
@@ -55,7 +55,7 @@ export function parseQuery<T extends ObjectLiteral = ObjectLiteral>(
 
         switch (key) {
             case Parameter.RELATIONS: {
-                const value = input[Parameter.RELATIONS] ?? input[URLParameter.RELATIONS];
+                const value = input[Parameter.RELATIONS] || input[URLParameter.RELATIONS];
                 if (value && isQueryParameterEnabled(options[Parameter.RELATIONS])) {
                     relations = parseQueryParameter(
                         key,
@@ -68,7 +68,7 @@ export function parseQuery<T extends ObjectLiteral = ObjectLiteral>(
                 break;
             }
             case Parameter.FIELDS: {
-                const value = input[Parameter.FIELDS] ?? input[URLParameter.FIELDS];
+                const value = input[Parameter.FIELDS] || input[URLParameter.FIELDS];
                 if (value && isQueryParameterEnabled(options[Parameter.FIELDS])) {
                     output[Parameter.FIELDS] = parseQueryParameter(
                         key,
@@ -80,7 +80,7 @@ export function parseQuery<T extends ObjectLiteral = ObjectLiteral>(
                 break;
             }
             case Parameter.FILTERS: {
-                const value = input[Parameter.FILTERS] ?? input[URLParameter.FILTERS];
+                const value = input[Parameter.FILTERS] || input[URLParameter.FILTERS];
                 if (value && isQueryParameterEnabled(options[Parameter.FILTERS])) {
                     output[Parameter.FILTERS] = parseQueryParameter(
                         key,
@@ -92,7 +92,7 @@ export function parseQuery<T extends ObjectLiteral = ObjectLiteral>(
                 break;
             }
             case Parameter.PAGINATION: {
-                const value = input[Parameter.PAGINATION] ?? input[URLParameter.PAGINATION];
+                const value = input[Parameter.PAGINATION] || input[URLParameter.PAGINATION];
                 if (value && isQueryParameterEnabled(options[Parameter.PAGINATION])) {
                     output[Parameter.PAGINATION] = parseQueryParameter(
                         key,
@@ -104,7 +104,7 @@ export function parseQuery<T extends ObjectLiteral = ObjectLiteral>(
                 break;
             }
             case Parameter.SORT: {
-                const value = input[Parameter.SORT] ?? input[URLParameter.SORT];
+                const value = input[Parameter.SORT] || input[URLParameter.SORT];
                 if (value && isQueryParameterEnabled(options[Parameter.SORT])) {
                     output[Parameter.SORT] = parseQueryParameter(
                         key,