fix: optimize array merge

tada5hi · May 20, 2023 · 240ce25 · 240ce25
1 parent f7d4a75
commit 240ce25
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/src/utils/array.ts b/src/utils/array.ts
@@ -22,16 +22,7 @@ export function distinctArray(arr: any[]) : any[] {
 }
 
 export function mergeArrays(...sources: any[][]) : any[] {
-    let merged = sources.shift();
-    if (!merged) {
-        return [];
-    }
-
-    for (let i = 0; i < sources.length; i++) {
-        merged = merged.concat(sources[i]);
-    }
-
-    return merged;
+    return ([] as any[]).concat.apply([], [...sources]);
 }
 
 export function mergeArraysDistinct(...sources: any[][]) : any[] {

diff --git a/test/unit/utils/array.spec.ts b/test/unit/utils/array.spec.ts
@@ -54,6 +54,10 @@ describe('src/utils/array', function () {
 
         expect(mergeArrays(['foo'], ['bar'])).toEqual(['foo', 'bar']);
 
+        expect(mergeArrays(['foo', 'bar'], ['baz'])).toEqual(['foo', 'bar', 'baz']);
+
+        expect(mergeArrays(['foo', 'bar'], [['baz']])).toEqual(['foo', 'bar', ['baz']]);
+
         expect(mergeArrays(['foo'], ['bar'], ['baz'])).toEqual(['foo', 'bar', 'baz']);
     })