New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bookstore: initialize project with components #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Tadesse-Alemayehu,
ππ Your project highlights π₯π
- General requirements β
- Components added flawlessly πͺ
Your project is complete! There is nothing else to say other than... it's time to merge it π§
Congratulations! π
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
"@testing-library/user-event": "^13.5.0", | ||
"react": "^18.1.0", | ||
"react-dom": "^18.1.0", | ||
"react-router-dom": "^6.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
react-router-dom
is present in package.json
β
<li><NavLink to="/">Book</NavLink></li> | ||
<li><NavLink to="/categories">Category</NavLink></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have 2 <Link>
s in the navbar which leads to the booklist and categories locations π₯
<Route path="/" element={<Books />} /> | ||
<Route path="/categories" element={<Categories />} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has 2 <Route>
s, one for the BookList component and the other for the Categories component β
- BookList component is the default page
return ( | ||
<div> | ||
{books.map((book) => ( | ||
<Book key={book.id} title={book.title} author={book.author} /> | ||
))} | ||
<AddNewBook /> | ||
</div> | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renders a list of books using the Book
component π₯
Renders a form by using the CreateNewBook component π
Dear @mateo951 Thank you, it's good to know I did right. π |
Changes introduced π
Node: π