Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookstore: initialize project with components #1

Merged
merged 10 commits into from Apr 28, 2022
Merged

Conversation

TadesseDev
Copy link
Owner

Changes introduced 😎


  • Initialize React app βœ”
  • Create reusable components/ βœ”

Books, Categories, Navigation βœ”
Also AddNewForm and single Book πŸ‘ŒπŸΌ

  • Add Initial HTML contents.

Node: πŸ“

Styles are not applied in this pull request. ✌

Copy link

@mateo951 mateo951 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Tadesse-Alemayehu,

πŸ“πŸ‘Œ Your project highlights πŸ”₯😎

  • General requirements βœ”
  • Components added flawlessly πŸ’ͺ

Your project is complete! There is nothing else to say other than... it's time to merge it 🧐

Congratulations! πŸŽ‰

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

"@testing-library/user-event": "^13.5.0",
"react": "^18.1.0",
"react-dom": "^18.1.0",
"react-router-dom": "^6.3.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-router-dom is present in package.json βœ”

Comment on lines +17 to +18
<li><NavLink to="/">Book</NavLink></li>
<li><NavLink to="/categories">Category</NavLink></li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have 2 <Link>s in the navbar which leads to the booklist and categories locations πŸ”₯

Comment on lines +14 to +15
<Route path="/" element={<Books />} />
<Route path="/categories" element={<Categories />} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has 2 <Route>s, one for the BookList component and the other for the Categories component βœ”

  • BookList component is the default page

Comment on lines +18 to +25
return (
<div>
{books.map((book) => (
<Book key={book.id} title={book.title} author={book.author} />
))}
<AddNewBook />
</div>
);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renders a list of books using the Book component πŸ”₯
Renders a form by using the CreateNewBook component 😎

@TadesseDev
Copy link
Owner Author

Dear @mateo951 Thank you, it's good to know I did right. πŸ‘

@TadesseDev TadesseDev merged commit 5be37ba into dev Apr 28, 2022
@TadesseDev TadesseDev deleted the initialize-project branch April 28, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants