Bookstore: styling #5
Conversation
✅ Deploy Preview for tadesse-bookstore ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Hi @Tadesse-Alemayehu
Good job so far! I know you have worked hard on making this milestone. There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️
- Kindly, make sure that the remove button is working as expected.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!:clap::clap::clap:
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Dear @Emmyn5600, I checked the review and re-evaluate my remove button. it seems working fine. Please can you review it again? |
|
Project Under Second Opinion Review. |
There was a problem hiding this comment.
Hello @Tadesse-Alemayehu 👋,
This is an additional review as a result of the second opinion request.
Great work with this project. 👍🏽
The remove button on the right actually works as you claim. This functionality should have been placed in the remove button on the left. I believe this is what the CR checked. But good that the functionality was working just fine.
As this was the only reason that your project was not approved it will be approved as soon as possible.
Please ask for another review in your Dashboard and the next Code Reviewer will mark it as approved right away :)
Keep rocking 🚀!
@mke2111 Thank you, Now I know what is missing I'll be more than happy to incorporate the changes. Thank you again for the second opinion. |
There was a problem hiding this comment.
Hi @Tadesse-Alemayehu,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- No linter errors ✅
- Github flow was used correctly 🚀
- Good design 💯
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
- N/A
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Thank you @prolajumokeoni 🙏🏼, Happy coding 😎 |
|
All is still perfect @Tadesse-Alemayehu 👍🏽 |
|
Thank you @mke2111 🙏🏼. |
Change introduces 😎