Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.6 計畫管理 計畫成員 #64

Open
5 of 6 tasks
ghost opened this issue Nov 21, 2018 · 15 comments
Open
5 of 6 tasks

3.6 計畫管理 計畫成員 #64

ghost opened this issue Nov 21, 2018 · 15 comments

Comments

@ghost
Copy link

ghost commented Nov 21, 2018

  • 3.6.1 列出計畫成員
  • (1) 點取「加入」
    • 輸入 ORCiD 直接 call ORCiD API,驗證有紀錄後直接以其人名建立成員(萬一不對再刪除即可)
    • 輸入 email 寄出邀請,邀請附上系統申請新帳號的連結
  • 帶入角色選單
  • 按X刪除成員
@ghost ghost mentioned this issue Nov 21, 2018
4 tasks
@ghost ghost added this to the 計畫資料管理及更新 milestone Nov 22, 2018
@ghost ghost added this to To do in API 介接及完成 UI 互動 via automation Nov 22, 2018
@ghost ghost assigned oahehc Dec 3, 2018
@trashmai
Copy link
Contributor

trashmai commented Dec 6, 2018

  • 列出計畫成員
    GET /project/:id/members
{
  "results": [
    {
      "_id": "OrcID_0000-0003-1335-0184",
      "name": "Guan Shuo Mai",
      "role": [
        {
          "projectId": "d8064aa7-9643-44fb-bed9-1f23a690f968",
          "role": "DataManager|ProjectManager|SysAdmin"
        }
      ]
    },
    {
      "_id": "OrcID_0000-0001-5912-1761",
      "name": "Chihjen Ko",
      "role": [
        {
          "projectId": "d8064aa7-9643-44fb-bed9-1f23a690f968",
          "role": "ProjectManager|ProjectInitiator"
        }
      ]
    },
    ...
  ]
}

@trashmai
Copy link
Contributor

trashmai commented Dec 6, 2018

@oahehc
Copy link
Collaborator

oahehc commented Dec 12, 2018

  1. 這功能要卡權限嗎?
  2. OrcID 要做格式驗證嗎?
  3. 這張 issue 要處理變更權限的部分嗎?

@ghost
Copy link
Author

ghost commented Dec 12, 2018

  1. 暫不
  2. 暫不

謝謝。

@oahehc
Copy link
Collaborator

oahehc commented Dec 12, 2018

    {
	  ...
      "role": [
        {
          "projectId": "d8064aa7-9643-44fb-bed9-1f23a690f968",
          "role": "ProjectManager|ProjectInitiator"
        }
      ]
    },

role array 內部的 role key 只會對應一個權限, 不應該有 ProjectManager|ProjectInitiator 這種的對嗎?

image

@ghost
Copy link
Author

ghost commented Dec 12, 2018

對的,那樣表示的意思是「或」喔

@oahehc
Copy link
Collaborator

oahehc commented Dec 12, 2018

如上截圖, 目前 DB 有些錯誤的資料喔, 有空時再請協助調整
(除了不應該出現 | 外, 應該也沒有 DataManager 這個 role)

@oahehc oahehc mentioned this issue Dec 12, 2018
@ghost
Copy link
Author

ghost commented Dec 13, 2018

剛和 @trashmai 討論過,確認一個人在一個計畫中只能有一個角色,所以上面的 API 結果格式應該要修改(不好意思!),然後 user collection 的資料也要清理過。我好了再告訴你喔。

@oahehc
Copy link
Collaborator

oahehc commented Dec 13, 2018

ok, 再提供影響到的 API 以及修改的 request/response 格式即可

@ghost
Copy link
Author

ghost commented Dec 24, 2018

@g11145590 @melissa0520 :
「計畫總覽的排序功能無效」

@ghost
Copy link
Author

ghost commented Dec 24, 2018

@g11145590 @melissa0520 :
『計畫管理>>計畫成員>>成員權限說明,點選後建議新增一個回上一頁的連結』

@oahehc
Copy link
Collaborator

oahehc commented Dec 24, 2018

計畫總覽的排序功能無效 => 我測是正常的
image
image

@oahehc
Copy link
Collaborator

oahehc commented Dec 24, 2018

計畫管理>>計畫成員>>成員權限說明,點選後建議新增一個回上一頁的連結
=> browser default 就有上一頁了, 確定需要再加上連結嗎? 如果確認要加有期望的位置跟樣式嗎?

@trashmai
Copy link
Contributor

trashmai commented Jan 3, 2019

如果要做返回上一頁連結,就用 <a class="btn btn-default" ...>在權限表的右上跟右下各擺一顆。

其實也可考慮用開新分頁,或是跳出 modal 顯示成員權限說明,個人覺得現在這樣換頁有點突兀。

@trashmai
Copy link
Contributor

trashmai commented Jan 3, 2019

計畫總覽排序那陣子我順手處理掉了,跟這個 issue title 無直接關連所以沒更新過來。

@oahehc oahehc mentioned this issue Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants