Add Python 3.5 to tox and travis config (fixes #44) #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
jmaupetit
added a commit
that referenced
this pull request
Nov 16, 2015
Add Python 3.5 to tox and travis config (fixes #44)
loonies
pushed a commit
to loonies/Watson
that referenced
this pull request
Feb 19, 2016
Add Python 3.5 to tox and travis config (fixes TailorDev#44)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run tox on travis via Python 3.5.
Fixes #44. Obsoletes #45.
The problem with Travis mentioned in #45 is that it does not find Python 3.5, when using the Python 2.7 environment. Since we use tox to run tests for different Python versions, the simple solution was to run tox always via Python 3.5. The magic trick with the build environment matrix mentioned here isn't needed in this case.