Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Rust code #21

Open
6 tasks
Tairesh opened this issue Jan 19, 2024 · 0 comments
Open
6 tasks

Refactoring Rust code #21

Tairesh opened this issue Jan 19, 2024 · 0 comments
Assignees
@Tairesh
Labels
meta Organizaion of code and lore development refactoring Rewrite code that is already (somehow) working
Milestone
Demo

Comments

@Tairesh
Copy link
Owner

Tairesh commented Jan 19, 2024 •
edited
Loading

  • Get rid of unwrap(), add Results or meaningful unwrap_or_else(|| panic!())
  • Gamescreens, in general. For example, shooting and throwing have 90% of code duplicated
  • Log messages: what avatar feels and what sees (will be needed after basic implementation of Monsters AI #7
  • Delete redundant "pub"s from mods/structs/enums/traits/functions
  • Make mods private by default, pub use internals if needed
  • Add #[inline] to simple functions
@Tairesh Tairesh added refactoring Rewrite code that is already (somehow) working meta Organizaion of code and lore development labels Jan 19, 2024
@Tairesh Tairesh self-assigned this Jan 19, 2024
@Tairesh Tairesh added this to the Demo milestone Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tairesh Tairesh

Labels
meta Organizaion of code and lore development refactoring Rewrite code that is already (somehow) working
Projects
None yet
Milestone
Demo
Development

No branches or pull requests
1 participant
@Tairesh