Bottom of button text cut off when using Font Awesome

[squeeish]

I'm new to iOS programming. I've noticed that if I have a prefix containing the letters "g", "p", etc, the bottom part of the text is cut off when I use font awesome icons by Vaberer's Font-Awesome-Swift library.

Do you have any hints to what might be causing this problem?

[ldiqual]

@squeeish Looks like a titleEdgeInsets issue to me. SwiftyButton plays with title insets internally so I'm not too surprised.

Would you mind sharing a code example so I can investigate further? Thank you!

[squeeish]

@ldiqual thanks! It's pretty simple:

https://github.com/Vaberer/Font-Awesome-Swift adds functions to UIButton, which I'm using as follows:

buttonLogin.setFAText(prefixText: "Log in ", icon: FAType.FALock, 
    postfixText: "", size: 14, forState: .Normal)

I took a look at Font-Awesome-Swift's library, this is the code of .setFAText. I'm not sure how to investigate further from here.

func setFAText(prefixText prefixText: String, icon: FAType?, postfixText: String, size: CGFloat?, forState state: UIControlState, iconSize: CGFloat? = nil) {

        if let titleLabel = titleLabel {

            FontLoader.loadFontIfNeeded()
            let textFont = UIFont(name: FAStruct.FontName, size: size ?? titleLabel.font.pointSize)
            assert(textFont != nil, FAStruct.ErrorAnnounce)
            titleLabel.font = textFont!

            let textAttribute = [NSFontAttributeName : titleLabel.font]
            let myString = NSMutableAttributedString(string: prefixText, attributes: textAttribute )

            if let iconText = icon?.text {

                let iconFont = UIFont(name: FAStruct.FontName, size: iconSize ?? size ?? titleLabel.font.pointSize)!
                let iconAttribute = [NSFontAttributeName : iconFont]

                let iconString = NSAttributedString(string: iconText, attributes: iconAttribute)
                myString.appendAttributedString(iconString)
            }

            let postfixString = NSAttributedString(string: postfixText)
            myString.appendAttributedString(postfixString)

            setAttributedTitle(myString, forState: state)
        }
    }

[ldiqual]

@squeeish I played a bit with your code and the library you linked to, and it turns out that using a regular UIButton causes the same issue:

So this bug is unrelated to SwiftyButton. From what I saw, it only happens when using the FA font, not when using the system font, so there's something wrong there (probably the line height). I'd suggest that you open an issue on the library's issue tracker.

Let me know if you need anything else! Closing this.

[squeeish]

I will. Thanks for taking the time to help me out!

[squeeish]

For anyone else who needs a solution to this, see Vaberer/Font-Awesome-Swift#20